Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FRDM-K66F Missing ADC pins mapping #10498

Closed
JarekParal opened this issue Apr 27, 2019 · 4 comments

Comments

Projects
None yet
4 participants
@JarekParal
Copy link
Contributor

commented Apr 27, 2019

Description
In the PeripheralNames.h and PeripheralPins.c missing configuration for ADC pins (PTB4, PTB5) declared in the NXP Header Pinout.

Issue request type
[ ] Question
[ ] Enhancement
[x] Bug

// add this line for PTB4
ADC1_SE10 = (1 << ADC_INSTANCE_SHIFT) | 10,
// add this line for PTB5
ADC1_SE11 = (1 << ADC_INSTANCE_SHIFT) | 11,

// add this line for PTB4
{PTB4 , ADC1_SE10, 0},
// add this line for PTB5
{PTB5 , ADC1_SE11, 0},

Could you consider adding these lines to master?

Thanks,
JarekParal

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

cc @ARMmbed/team-nxp Please review

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

Could you consider adding these lines to master?

Please create a pull request, fixing these lines, will be reviewed.

0xc0170 added a commit that referenced this issue Apr 30, 2019

Merge pull request #10506 from JarekParal/fix-k66-missing-adc-pins-ma…
…pping

Add missing ADC pins mapping for FRMD-K66F (#10498)
@linlingao

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

Looks like the fix is merged. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.