Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaps in QSPIFBlockDevice SFDP Implementation #11530

Closed
kyle-cypress opened this issue Sep 19, 2019 · 4 comments

Comments

@kyle-cypress
Copy link

@kyle-cypress kyle-cypress commented Sep 19, 2019

Description

In several cases QSPIFBlockDevice does not conform to the SFDP standard JESD216. These include:

  • Status register reading and writing
  • Soft resetting
  • Enabling of 4-byte addressing
  • Enabling of quad output mode
  • Use of the legacy erase instruction

In these cases QSPIFBlockDevice often assumes that certain instructions or methods are universal across flash devices when they are not. This can cause issues in devices that do not match these assumptions. We will be submitting a pull request shortly to resolve many of these issues and better align QSPIFBlockDevice with JESD216.

Issue request type

[ ] Question
[ ] Enhancement
[x] Bug
@ciarmcom

This comment has been minimized.

Copy link
Member

@ciarmcom ciarmcom commented Sep 19, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

@0xc0170 0xc0170 commented Sep 20, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

@adbridge adbridge commented Nov 21, 2019

@kyle-cypress can this be closed now ?

@kyle-cypress

This comment has been minimized.

Copy link
Author

@kyle-cypress kyle-cypress commented Nov 21, 2019

Yes, the PR #11531 that fixes this has been merged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.