Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Cannot use private "_is_connected" flag. #11606

Closed
mudassar-ublox opened this issue Oct 1, 2019 · 4 comments
Closed

Cellular: Cannot use private "_is_connected" flag. #11606

mudassar-ublox opened this issue Oct 1, 2019 · 4 comments

Comments

@mudassar-ublox
Copy link
Contributor

@mudassar-ublox mudassar-ublox commented Oct 1, 2019

In cellular api's _is_connected flag is private and is used in do_connect function and do_connect is virtual. How child classes can use this flag, _is_connected. when do_connect is overridden child classes.

Also when do_connect is overridden then we cannot set this flag, _is_connected . So while calling do_disconnect because of _is_connected this check become true and sets _cid = -1 and when deactivate_context function is called give error. It will be better to add some method to set _is_connected.

[INFO][CELL]: AT TX (11): AT+CGACT=0,
[INFO][CELL]: AT TX ( 2): -1
[INFO][CELL]: AT TX ( 1):
[INFO][CELL]: AT RX ( 9): ERROR

Issue request type

[ ] Question
[ ] Enhancement
[x] Bug
@mudassar-ublox

This comment has been minimized.

Copy link
Contributor Author

@mudassar-ublox mudassar-ublox commented Oct 1, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

@0xc0170 0xc0170 commented Oct 1, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

@ciarmcom ciarmcom commented Oct 1, 2019

@kivaisan

This comment has been minimized.

Copy link
Contributor

@kivaisan kivaisan commented Nov 5, 2019

@ARMmbed/mbed-os-maintainers , I think this issue can be closed. Fix has been merged a long time ago.

@0xc0170 0xc0170 closed this Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.