Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32F767ZI - I2C FastModePlus not properly enabled #11659

Closed
durets opened this issue Oct 9, 2019 · 2 comments · Fixed by #11672
Closed

STM32F767ZI - I2C FastModePlus not properly enabled #11659

durets opened this issue Oct 9, 2019 · 2 comments · Fixed by #11672

Comments

@durets
Copy link

@durets durets commented Oct 9, 2019

Description
@LMESTM
mbed 5.9.7

Following HAL update, MACRO __HAL_SYSCFG_FASTMODEPLUS_ENABLE has been replaced by I2C API function HAL_I2CEx_EnableFastModePlus.

In targets/TARGET_STM/i2c_api.c

#if defined(I2C1_BASE) && defined(__HAL_SYSCFG_FASTMODEPLUS_ENABLE) && defined (I2C_FASTMODEPLUS_I2C1)
if (obj_s->i2c == I2C_1) {
HAL_I2CEx_EnableFastModePlus(I2C_FASTMODEPLUS_I2C1);
}

However, macro __HAL_SYSCFG_FASTMODEPLUS_ENABLE being now undefined, i guess we have to remove it in order to properly enable I2C FastModePlus.

Proposal:

#if defined(I2C1_BASE) && defined (I2C_FASTMODEPLUS_I2C1)
if (obj_s->i2c == I2C_1) {
HAL_I2CEx_EnableFastModePlus(I2C_FASTMODEPLUS_I2C1);
}

Issue request type
[ ] Question
[ ] Enhancement
[x] Bug

@LMESTM

This comment has been minimized.

Copy link
Contributor

@LMESTM LMESTM commented Oct 9, 2019

Thanks @durets

@ABOSTM @jeromecoutant
at first glance, the proposed fix makes senses (to be applied to all the I2C instances).
can you have a look and create a corresponding Pull Request ?

@ciarmcom

This comment has been minimized.

Copy link
Member

@ciarmcom ciarmcom commented Oct 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.