Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep_sleep_lock Ticker.h Issue #7308

Closed
tpet93 opened this Issue Jun 25, 2018 · 6 comments

Comments

Projects
None yet
6 participants
@tpet93
Copy link

tpet93 commented Jun 25, 2018

Description

In Ticker.h, Ticker::attach_us(Callback<void()> func, us_timestamp_t t) is defined and not just declared.
This causes an issue with the line 119 sleep_manager_lock_deep_sleep();

The deep sleep manager tracks sleep locks using the file name.
the deep sleep lock is placed in "Ticker.h" and removed in "Ticker.cpp"
(line 30)
this causes the sleep manager lock counter to lose count,

Solution

Moving the definition of Ticker::attach_us(Callback<void()> func, us_timestamp_t t)
to Ticker.cpp from Ticker.h solves the issue.

Issue request type

[ ] Question
[ ] Enhancement
[X] Bug

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Jun 25, 2018

Thank you for reporting and also providing a solution, we will review soon
[Mirrored to Jira]

@ARMmbed ARMmbed deleted a comment from ciarmcom Oct 2, 2018

@adbridge

This comment has been minimized.

Copy link
Contributor

adbridge commented Oct 4, 2018

Internal Jira reference: https://jira.arm.com/browse/IOTHAL-233

@mprse

This comment has been minimized.

Copy link
Member

mprse commented Jan 24, 2019

I'm looking on this one.

@mprse

This comment has been minimized.

Copy link
Member

mprse commented Jan 24, 2019

Analysis and patch can be found here: PR #9483.

Fixed as suggested by @tpet93 .

Thanks @tpet93 !

0xc0170 added a commit that referenced this issue Jan 29, 2019

Merge pull request #9483 from mprse/ticker_sleep_lock_fix
Fix for Issue #7308 (Deep_sleep_lock Ticker.h Issue)
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Jan 29, 2019

@tpet93 👍 for the bug report with suggestions how to fix.

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Jan 30, 2019

Closing since issue appears to be resolved. Please reopen if this is not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.