Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update device peripherals for STM32 series #8626

Closed
AGlass0fMilk opened this Issue Nov 2, 2018 · 5 comments

Comments

Projects
None yet
5 participants
@AGlass0fMilk
Copy link
Contributor

AGlass0fMilk commented Nov 2, 2018

Description

Targets in the STM32F4 family have inconsistent "Device Has" peripherals defined. For example, I was working with the STM32F407VG-based discovery board and found that targets.json did not enable "SERIAL_FC" or "SERIAL_ASYNCH".

I dug a little deeper and found some STM32F4 targets that do enable these peripherals. I also found that all STM32F4 targets share the same serial_api.c HAL implementation, so if one supports these peripherals then they all can. I modified my target's "device_has" field to include "SERIAL_FC" and it worked without issue.

It took me a bit to debug this and I'd like to save everyone time in the future. I think targets need to be gone through (at least in the STM32 family) and peripherals sets should be updated.

Issue request type

[ ] Question
[ ] Enhancement
[ X ] Bug
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Nov 2, 2018

@bcostm

This comment has been minimized.

Copy link
Contributor

bcostm commented Nov 4, 2018

Hi
The DISCO_F407 is one of the ST boards that has been added by community and not by ST team in the past, so it may have some features/files not well defined compared to other "official" boards. If you already have done the change and tested it ok, why don't you send a PR ? We'll review it. Thanks

@TacoGrandeTX

This comment has been minimized.

Copy link
Contributor

TacoGrandeTX commented Jan 28, 2019

@aglassofmilk - We are performing a review of all open/stale issues. We know you are focused on adding nRF52840 USB driver support so would you like us to close this issue? We can always re-open it if you want to pursue it later.

@AGlass0fMilk

This comment has been minimized.

Copy link
Contributor Author

AGlass0fMilk commented Jan 30, 2019

Yeah, I don't primarily work on ST targets so I probably won't get around to this in the near future... It should be documented somewhere so no one else wastes hours of time debugging issues.

I guess anyone using targets that aren't "officially" Mbed-enabled should beware.

@jeromecoutant

This comment has been minimized.

Copy link
Contributor

jeromecoutant commented Jan 30, 2019

Please check #9553
Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.