Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analogin_device.c doesn't clear internal buffer for Vref #9504

Closed
RobVlaar opened this Issue Jan 25, 2019 · 2 comments

Comments

Projects
None yet
4 participants
@RobVlaar
Copy link

RobVlaar commented Jan 25, 2019

Description

  • type: bug

Bug

Target
STM32L072CZ

Files
analogin_device.c
stm32l0xx_hal_adc.c

mbed-os
5.10.0

Issue
We use the smt32l072cz for a couple of applications and it uses about 3µA. With a new application we want to use the internal Vref. The usage of it is verry simple but the issue is, it doesn't automaticly turns off its internal buffer when the analog in is destructed. With its internal buffer still on it uses an additional 10µA.
We have fixed the issue by configuring the channel with a rank of ADC_RANK_NONE before the adc data is returned. When configuring with a ADC_RANK_NONE the internal buffer is turned off in stm32l0xx_hal_adc.c and doesn't use the addidtional 10µA.

Question
Should I do a pull request for the issue or should it be fixed somewhere else?

@RobVlaar RobVlaar changed the title analogin_device.c doesn't clear internal buffer analogin_device.c doesn't clear internal buffer for Vref Jan 25, 2019

@jeromecoutant

This comment has been minimized.

Copy link
Contributor

jeromecoutant commented Jan 25, 2019

Hi
Please, submit a PR, we will review it.
Regards,

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.