Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for SDP-K1. #10000

Merged
merged 9 commits into from Mar 27, 2019

Conversation

@malavikasajikumar
Copy link
Contributor

commented Mar 7, 2019

Description

This pull request contains files to support SDP-K1 board on Mbed. This board uses STM32F469NI Cortex-M4 processor.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from screamerbg and ARMmbed/mbed-os-maintainers Mar 7, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

@malavikasajikumar, thank you for your changes.
@screamerbg @ARMmbed/mbed-os-maintainers please review.

@ChiefBureaucraticOfficer

This comment has been minimized.

Copy link

commented Mar 7, 2019

Conditionally Approved for 5.12 - if risk is low and no side effects to other targets, this is approved.
(Also congrats on # 10,000)

@cmonr cmonr added do not merge and removed do not merge labels Mar 8, 2019

@cmonr cmonr requested a review from ARMmbed/team-st-mcd Mar 8, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

@malavikasajikumar Please update the description.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

Adding support for SDP-K1. #10000

💯x💯 👍 🎉 🍾

@cmonr What description should be updated?

entire PR template - PR description and PR type - provide information about what are you introducing

@bulislaw
Copy link
Member

left a comment

Please remove the dead (commented out) code and provide test results for all 3 compilers.

Show resolved Hide resolved targets/targets.json Outdated
Show resolved Hide resolved targets/targets.json Outdated
@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

New target needs pasting test logs for all 3 toolchains, please attach them to the pull request

Besides these minor comments, LGTM

@0xc0170 0xc0170 requested a review from ashok-rao Mar 8, 2019

@malavikasajikumar

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

What is causing this CI test failure?
https://travis-ci.org/ARMmbed/mbed-os/jobs/503729968

@malavikasajikumar

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2019

@cmonr @0xc0170 @bulislaw

Test log files for GCC_ARM. Separately attached the log file for mbed-os-tests-mbedmicro-rtos-mbed-mutex timeout.

SDP-K1_GCC-ARM.log
SDP-K1_GCC-ARM_rtos-mbed-mutex.log

Test log files

SDP-K1_ARM.log
SDP-K1_ARM_mbed_platform-stream.log
SDP-K1_ARM_mbed_platform-critical_section.log

@malavikasajikumar

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2019

Moved back for RC2 to make sure this isn't lost.

If it can pass testing in time, it can make it into RC2. Otherwise, we can look at a branch or other alternatives.

CC @bentcooke

Test log files uploaded.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 12, 2019

Test run: FAILED

Summary: 3 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR8
  • jenkins-ci/mbed-os-ci_build-ARMC6
@@ -3694,6 +3694,42 @@
"device_name": "STM32F469NI",
"bootloader_supported": true
},
"SDP-K1": {

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Mar 12, 2019

Member

SDP_K1 should be the name (as any other target). The failure in the build might be related (as it cant find the target) - this could be a bug in our tools or rather unsupported feature

cc @ARMmbed/mbed-os-tools

This comment has been minimized.

Copy link
@malavikasajikumar

malavikasajikumar Mar 12, 2019

Author Contributor

Would that be a cause of CI test failures? The name with hyphen is consistent across all the supporting files. @bentcooke

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Mar 12, 2019

Member

I believe yes. You should be able to reproduce the build failure locally. To be consistent, it should use _ instead. (review any other targets). This follows also directory naming TARGET_ and others.

This comment has been minimized.

Copy link
@malavikasajikumar

malavikasajikumar Mar 15, 2019

Author Contributor

@0xc0170 @bentcooke Fixed the hyphen to underscore, ran the tests on IAR toolchain.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

Moving back to 5.12.1, 5.12.0-rc2 is now ready and going to be released

@malavikasajikumar

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

Moving back to 5.12.1, 5.12.0-rc2 is now ready and going to be released

Guess we will have to go with a separate branch then, that can be imported into mbed compiler. @cmonr

@theotherjimmy

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

@malavikasajikumar Please don't use another branch (it would have to be a fork, FYI) to import into the online compiler. Mbed OS is cached and this strategy skips the cache and costs ARM GB of storage for every import.

@malavikasajikumar

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

@bulislaw

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

We can't merge the platform support with failing tests. Can you please debug it to get to the bottom of the issues?

@malavikasajikumar

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

We can't merge the platform support with failing tests. Can you please debug it to get to the bottom of the issues?

The tests that timed out were run again and were successful. The second log files (SDP_K1_IAR_test_TIMEOUTS.log and SDP_K1_GCC_ARM_test_TIMEOUTS.log) shows these tests succeeding. Could you confirm? @bulislaw

@malavikasajikumar

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

Thank you for the approval. @bulislaw

@ashok-rao @0xc0170 Please let us know if there are anymore changes/updates needed.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

CI started

@cmonr cmonr added needs: review and removed needs: work labels Mar 26, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 26, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr requested a review from 0xc0170 Mar 26, 2019

@cmonr cmonr added ready for merge and removed needs: review labels Mar 26, 2019

@cmonr

cmonr approved these changes Mar 26, 2019

Changes addressed

cmonr added a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019

@cmonr cmonr merged commit b872d08 into ARMmbed:master Mar 27, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9999 cycles (-330 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 27, 2019

@malavikasajikumar

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

Thank you! @cmonr @bentcooke @0xc0170 @bulislaw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.