Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable PSA in baremetal profiles #10002

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
7 participants
@kegilbert
Copy link
Contributor

commented Mar 7, 2019

Description

Allows BareMetal profiles to build when PSA is present on master. Currently breaks baremetal compiles without this.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SenRamakri @theotherjimmy @orenc17

Release Notes

@orenc17
Copy link
Contributor

left a comment

Maybe just remove PSA from extra labels?

@kegilbert kegilbert changed the title Add PSA lib file Disable PSA in baremetal profiles Mar 7, 2019

@ChiefBureaucraticOfficer
Copy link

left a comment

Meets criteria, needed to support new feature PSA & Bare Metal. Approved.

@orenc17

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

@kegilbert @ChiefBureaucraticOfficer which platform is broken on bare-metal?

@mikisch81
Copy link
Contributor

left a comment

This must be verified on #9910 that it does not break the secure target build.
@mmahadevan108 FYI

@kegilbert kegilbert force-pushed the kegilbert:psa_baremetal_fix branch to 3fd3288 Mar 7, 2019

@kegilbert

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

@orenc17 PSA compliant targets are broken (specifically found the issue on the K64F).

@orenc17

orenc17 approved these changes Mar 7, 2019

Copy link
Contributor

left a comment

Looks fine to me @kegilbert supplied build log with #9910
@ARMmbed/mbed-os-maintainers i would still prefer to merge this AFTER #9910 is merged

P.S. sorry for the caps...i get cranky code reviewing at 1AM

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

i get cranky code reviewing at 1AM

Mabe you should get some sleep 😁

@0xc0170

0xc0170 approved these changes Mar 8, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 8, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

Starting CI

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

@ARMmbed/mbed-os-maintainers i would still prefer to merge this AFTER #9910 is merged

@orenc17

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

@cmonr Beware, people will think you're angry

@ARMmbed/mbed-os-maintainers i would still prefer to merge this AFTER #9910 is merged

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 8, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 removed the needs: CI label Mar 8, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

#9910 merged, can this go in?

@orenc17

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

Yes

@0xc0170 0xc0170 merged commit b9c214b into ARMmbed:master Mar 8, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10432 cycles (+228 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.