Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M2351: Support memory custom partition #10004

Merged

Conversation

Projects
None yet
7 participants
@ccli8
Copy link
Contributor

commented Mar 8, 2019

Description

Relying on #10008, this PR tries to add back support for ROM/RAM custom partition and address related #8757 which updates M2351 CMSIS pack and changes memory spec from single secure ROM/RAM block to separate secure/non-secure ROM/RAM blocks.

Related issue or PR

#10008
#8757

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

ccli8 added some commits Jan 15, 2019

[M2351] Rename TOOLCHAIN_ARM_STD TOOLCHAIN_ARMC6
This is to express ARMC6 toolchain support more explicitly.
[M2351] Refactor for memory partittion support
Add partition_M2351_mem.h/partition_M2351_mem.icf to centralize memory partition
[M2351] Override CMSIS ROM/RAM spec in targets.json
Old M2351 CMSIS pack reports single secure ROM/RAM spec. It is updated in new
version which reports secure/non-secure ROM/RAM spec. Override this memory spec
in targets.json regardless of CMSIS.

@ciarmcom ciarmcom requested review from Ronny-Liu and ARMmbed/mbed-os-maintainers Mar 8, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

@ccli8, thank you for your changes.
@Ronny-Liu @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-tools please review.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

Commmit fa975ad4924b6f88d364ff62e4e15008515744ec - can this be sent separately? Tools team would review (the rest of commits are target related).

@ccli8 ccli8 force-pushed the OpenNuvoton:nuvoton_m2351_fix-memory-partition branch to c4bda55 Mar 8, 2019

@ccli8

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

@0xc0170 Commmit fa975ad - can this be sent separately? Tools team would review (the rest of commits are target related).

Separate to #10008.

@bridadan

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

@0xc0170 since that commit was removed from this PR I'll go ahead and dismiss the mbed-os-tools review.

@bridadan bridadan removed the request for review from ARMmbed/mbed-os-tools Mar 8, 2019

@0xc0170
Copy link
Member

left a comment

License addition to the new sct file

@@ -0,0 +1,82 @@
/* See partition_M2351_mem.h for documentation */

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Mar 11, 2019

Member

please add license header to all new files if not yet in, like this one

This comment has been minimized.

Copy link
@ccli8

ccli8 Mar 12, 2019

Author Contributor

@0xc0170 Added license header.

@cmonr cmonr requested a review from 0xc0170 Mar 13, 2019

@ccli8

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

With #10008 merged, any update?

License header added.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@ccli8 Who are you asking?

@ccli8

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

@cmonr This PR relies on #10008. With #10008 having merged into mainline, how about this PR's progress?

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

I'm still not sure I understand. Are you saying that this is ready to progress now that #10008 is merged?

@ccli8

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

@cmonr Yes, please go ahead.

@cmonr cmonr requested a review from ARMmbed/team-nuvoton Mar 28, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

@ARMmbed/team-nuvoton Please review.

@cmonr

cmonr approved these changes Mar 28, 2019

Copy link
Contributor

left a comment

LGTM

@ccli8

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

@cyliangtw
Copy link
Contributor

left a comment

Some duplicate rom/ram default settings in partition_M2351_mem.h and target.json .
Remind to remove the one in partition_M2351_mem.h after tool mature enough.

@0xc0170

0xc0170 approved these changes Apr 9, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Ci started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 9, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Apr 9, 2019

@cmonr cmonr merged commit 73f1edd into ARMmbed:master Apr 9, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10090 cycles (+221 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.