Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cellular: remove last CELLULAR_DEVICE references #10005

Merged
merged 1 commit into from Mar 20, 2019

Conversation

Projects
None yet
7 participants
@TeemuKultala
Copy link
Contributor

commented Mar 8, 2019

Description

CellularTargets.h removed to get rid of last CELLULAR_DEVICE references. Tested with the cellular example

Pull request type

[ X ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AriParkkila

@ciarmcom ciarmcom requested review from AriParkkila and ARMmbed/mbed-os-maintainers Mar 8, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

@TeemuKultala, thank you for your changes.
@AriParkkila @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@0xc0170

0xc0170 approved these changes Mar 8, 2019

@AriParkkila
Copy link
Contributor

left a comment

Remove CellularTargets.h also from features/cellular/TESTS.

Change doxygen of CellularDevice.h to something like "Returns singleton instance of CellularDevice if Mbed target board has a supported onboard modem or provide-default is defined for a cellular driver in JSON configuration files, otherwise returns NULL. See NetworkInterface::get_default_instance for details."

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

@AriParkkila Please rereview

@TeemuKultala When push an update, please leave a comment what has changed (helps reviewers to get back to you with additional questions or approval)

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

I've just noticed, this needs rebase now

@cmonr cmonr added needs: CI and removed needs: work labels Mar 15, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 16, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 16, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

Hmm, there was a slghtly older cellular PR that just came in that's caused this PR to need a rebase.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Mar 18, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

CI restarted

@TeemuKultala When rebased , please let us know via comment

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 18, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 18, 2019

@0xc0170 0xc0170 merged commit c6d3d83 into ARMmbed:master Mar 20, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10304 cycles (+1112 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@TeemuKultala TeemuKultala deleted the TeemuKultala:cellular_remove_device branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.