Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uARM - Move heap region after IRAM1 #10019

Merged
merged 1 commit into from Apr 18, 2019

Conversation

Projects
None yet
7 participants
@deepikabhavnani
Copy link
Contributor

commented Mar 8, 2019

Description

ARM_LIB_HEAP start is aligned to IRAM1 end, hence should be placed next to RW_IRAM1 i.e. no other region in between.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from maclobdell, MarceloSalazar, screamerbg and ARMmbed/mbed-os-maintainers Mar 8, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

@cmonr cmonr requested a review from ARMmbed/team-nxp Mar 27, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

Closing for now since @deepikabhavnani is out until 2nd week of April.

@cmonr cmonr closed this Mar 27, 2019

@cmonr cmonr removed the needs: review label Mar 27, 2019

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

@ARMmbed/mbed-os-maintainers - Can we please reopen this?

@cmonr cmonr reopened this Apr 9, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

@deepikabhavnani Done!

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

uARM - Move heap region after IRAM1
ARM_LIB_HEAP start is aligned to IRAM1 end, hence should be placed next to
RW_IRAM1 i.e. no other region in between.

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:uarm_fix branch from b4780a3 to 36c7b2d Apr 9, 2019

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

Rebased to re-trigger CI, and pick up latest fixes.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 10, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 10, 2019

Test run: FAILED

Summary: 6 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
@alekla01

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

Restarted jenkins-ci

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 10, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 removed the needs: CI label Apr 11, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

@ARMmbed/team-nxp Please review

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

We would like to proceed with this PR

@0xc0170 0xc0170 removed the request for review from screamerbg Apr 15, 2019

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

Was CI triggered accidentally on this PR again? Not sure why continuous-integration/jenkins/pr-head is X

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

@deepikabhavnani Something like that. I think @ARMmbed/mbed-os-test-team are working on CI auto-triggering.

The current config doesn't have a way to indicate that a job was aborted.

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 17, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 17, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 6
Build artifacts

@0xc0170 0xc0170 merged commit b6a2c7b into ARMmbed:master Apr 18, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10138 cycles (-49 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.