Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add needed crypto macros to secure side #10026

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
10 participants
@NirSonnenschein
Copy link
Contributor

commented Mar 10, 2019

Description

The PSA crypto / mbedTLS configuration to the non-secure side of the PSA NXP board was configured to support AES CTR encryption but the tfm build [secure size] was not (which caused failures in the compliance test due to unsupported features). This PR should make the configurations the same for both builds and allow the tests to pass.
Note: this change is also important for secure store functionality
Also Note: This is a small fix to a problem which will required a more architectural solution to how we keep these two configurations synchronized in platforms where the images are built using different procedures.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@avolinski @itayzafrir

Release Notes

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

@ciarmcom ciarmcom requested review from avolinski, itayzafrir and ARMmbed/mbed-os-maintainers Mar 10, 2019

@itayzafrir
Copy link
Contributor

left a comment

Looks OK as a workaround, I agree with Nir that this a more resilient solution in the future.

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2019

started CI while waiting for reviews

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 10, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 removed the request for review from ARMmbed/mbed-os-tools Mar 11, 2019

@0xc0170 0xc0170 merged commit 9f4c918 into ARMmbed:master Mar 11, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9175 cycles (-847 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
@theotherjimmy

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

Please either:

  1. Wait for all requested reviewers to review
  2. Don't request reviewers that you are not going to block the PR on.

I think for mbed_lib.json, that mbed-os-tools may be taken off the reviewers list.

@mikisch81

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

Please either:

1. Wait for all requested reviewers to review

2. Don't request reviewers that you are not going to block the PR on.

I think for mbed_lib.json, that mbed-os-tools may be taken off the reviewers list.

@theotherjimmy this ciarmcom user should behave next time.. 😄

@theotherjimmy

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

bad misbehaving bot. 😛

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

It's a simple bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.