Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSA: release.py updates to fixes situation where the script would get stuck #10038

Merged
merged 1 commit into from Mar 12, 2019

Conversation

Projects
None yet
7 participants
@orenc17
Copy link
Contributor

commented Mar 11, 2019

Description

  • Remove stdout redirection.
  • use git diff --quiet

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@adbridge

Release Notes

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

@orenc17 Is this essential for 5.12 or should we see if it works first and if so just bring this in for 5.12.1 ?

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2019

The script seem to get stuck on big git diffs, so yes this is crucial
Sorry for the mess

@adbridge
Copy link
Contributor

left a comment

AFAICT looks ok to me

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

@orenc17 I assume this latest change has been fully tested ?

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2019

Yes

@0xc0170
Copy link
Member

left a comment

Minnor changes fixing the script from getting stuck

Can you add to the commit msg - what errors is this fixing - big diffs or similar you already mentioned.

What use cases are being fixed here is the question to be answered

Minor changes fixing the script from getting stuck
* git diff of bin/hex files could be huge print and make
* calling python unbuffered with stdout=subprocess.PIPE could be problematic

@orenc17 orenc17 force-pushed the kfnta:tool_fix branch to dad75b5 Mar 11, 2019

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2019

@0xc0170 Fixed commit message

@0xc0170
Copy link
Member

left a comment

+1 for the commit msg update

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 11, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

ci started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 11, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

@cmonr CI has passed, should be ready to merge pending approval by @ChiefBureaucraticOfficer.

@ChiefBureaucraticOfficer
Copy link

left a comment

Meets criteria, PSA. Approved.

@cmonr cmonr merged commit bf6e6ee into ARMmbed:master Mar 12, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9925 cycles (-382 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.