Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSA: release.py bugfix - send the correct parameter to _get_target_info() #10046

Merged
merged 1 commit into from Mar 12, 2019

Conversation

Projects
None yet
4 participants
@orenc17
Copy link
Contributor

commented Mar 12, 2019

Description

  • send the correct parameter to _get_target_info()

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@adbridge

Release Notes

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

Sufficient to have in rc3?

@0xc0170 0xc0170 requested a review from adbridge Mar 12, 2019

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

rc2... i'm sorry, the tool is already integrated into the mbed-os-release

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

CI started

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

@orenc17 is there anything else we should expect?

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

(hopefully) no.

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 12, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

CI completed successfully , this is ready pending rc approval

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

@0xc0170 Neil has approved merge into rc2 for this one.

@0xc0170 0xc0170 merged commit 401a3c8 into ARMmbed:master Mar 12, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(-36 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9294 cycles (-1389 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@orenc17 orenc17 deleted the kfnta:another_tool_fix branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.