Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSA more options in release tool #10070

Merged
merged 10 commits into from Mar 27, 2019

Conversation

Projects
None yet
8 participants
@orenc17
Copy link
Contributor

commented Mar 12, 2019

Description

  • Added logging infrastructure.
  • Added -v for verbose
  • Added --skip-tests to build only the main image.
  • Added -l to list PSA platforms.
  • Added -x to send extra argument to the build command such as -D

Note to maintainers: this is for 5.12.1

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Mar 12, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

@orenc17, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@theotherjimmy
Copy link
Contributor

left a comment

Nothing looks out of the ordinary here.

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

@ARMmbed/mbed-os-maintainers do not merge yet
I still need to update docs and maybe more features

@orenc17 orenc17 changed the title [PSA] more options in release tool [PSA] more options in release tool - WIP Mar 12, 2019

@0xc0170 0xc0170 changed the title [PSA] more options in release tool - WIP PSA more options in release tool - WIP Mar 13, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

@cmonr your review is very much a must here !

@cmonr cmonr self-requested a review Mar 13, 2019

@orenc17 orenc17 force-pushed the kfnta:tool_options branch from 2ee5ace to 24babc7 Mar 20, 2019

@orenc17 orenc17 changed the title PSA more options in release tool - WIP PSA more options in release tool Mar 20, 2019

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

Finished with the changes.. ready for CI

@0xc0170 0xc0170 added needs: review and removed needs: work labels Mar 20, 2019

@cmonr

cmonr approved these changes Mar 20, 2019

Copy link
Contributor

left a comment

LGTM!


subprocess.check_call([
sys.executable, MAKE_PY_LOCATTION,
'mbed', 'test', '--compile',

This comment has been minimized.

Copy link
@cmonr

cmonr Mar 20, 2019

Contributor

🎉

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

CI started

@cmonr cmonr added needs: CI and removed needs: review labels Mar 20, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 20, 2019

Test run: FAILED

Summary: 4 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR8
  • jenkins-ci/mbed-os-ci_build-ARMC5
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARMC6
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

CI restarted.

Confirming PR has issues, since build failures seemed odd.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

CI restarted.

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 20, 2019

Test run: FAILED

Summary: 4 of 9 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARMC5
  • jenkins-ci/mbed-os-ci_build-IAR8
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARMC6
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 20, 2019

Test run: FAILED

Summary: 7 of 9 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARMC5
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR8
  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-ARMC5
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR8
  • jenkins-ci/mbed-os-ci_build-ARMC6
@mbed-ci

This comment has been minimized.

Copy link

commented Mar 21, 2019

Test run: FAILED

Summary: 4 of 9 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARMC5
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR8
  • jenkins-ci/mbed-os-ci_build-ARMC6
@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

@ARMmbed/mbed-os-maintainers can you run again? i've reverted back parts of the implementation to the previous one

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

@oren will there be additional changes required to the mbed-os release script to use some of these new options ?

this PR will make the PSA script verbose, if you want to disable most of the prints we'll need to add -q to mbed-os release script

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

@adbridge the new -x feature is tested with the psa-compliance example repo

orenc17 added some commits Mar 20, 2019

Overhaul logging and verbosity
* Default verbose
* -q for quiet build with minimal status prints
Refactor
* Use default image command generator.
* Call directly to mbed-cli.
* Add --skip-tests.

@orenc17 orenc17 force-pushed the kfnta:tool_options branch from b067e13 to d012b3a Mar 26, 2019

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

Starting CI

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 26, 2019

Test run: FAILED

Summary: 4 of 9 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARMC5
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR8
  • jenkins-ci/mbed-os-ci_build-ARMC6
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

Will start CI for now, but the last commit points to something interesting.

@orenc17 What kind of local testing was done prior to the PR?

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

CI started

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

@cmonr i tried to implement the extra parameter with and without a leading symbol (-x in my case).
when i didn't define the leading symbol i always got an empty array when no extra params were sent.
when i did define the leading symbol i got a None when no extra params were sent.
that is why i needed to add default=[] in the last commit

cmonr added a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 26, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 7
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

CI job restarted: jenkins-ci/dynamic-memory-usage

Dunno why this failed with this PR to begin with.

| GCC_ARM-K66F | K66F | ethernet | TIMEOUT | 92.05 | default |

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 27, 2019

@cmonr cmonr merged commit 7e7f4f5 into ARMmbed:master Mar 27, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10442 cycles (+1316 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.