Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding variable length attributes to Maxim Feather #10072

Merged
merged 2 commits into from Mar 29, 2019

Conversation

Projects
None yet
9 participants
@nick-atmosphereiot
Copy link
Contributor

commented Mar 12, 2019

Description

The Max Feather board does not currently handle variable length attributes. With the released version of mbed-os, all attribute writes that are not maxLen are ignored.

This fix is tested locally with a MAX32630Fthr board using the BLE Scanner Android App to manually write attributes.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Mar 13, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

@nick-atmosphereiot, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from ARMmbed/team-maximintegrated Mar 13, 2019

@@ -146,6 +146,12 @@ ble_error_t MaximGattServer::addService_(GattService &service)
currAtt->pLen = p_char->getValueAttribute().getLengthPtr();
currAtt->maxLen = p_char->getValueAttribute().getMaxLength();
currAtt->settings = ATTS_SET_WRITE_CBACK | ATTS_SET_READ_CBACK;

if(p_char->getValueAttribute().hasVariableLength())
{

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Mar 13, 2019

Member

should follow the style in this file { on the same line as if

This comment has been minimized.

Copy link
@nick-atmosphereiot

nick-atmosphereiot Mar 13, 2019

Author Contributor

@0xc0170 Good catch, fixed. :)

@cmonr cmonr requested a review from 0xc0170 Mar 13, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@Team-MaximIntegrated @ARMmbed/mbed-os-pan Thoughts?

@cmonr

cmonr approved these changes Mar 27, 2019

@pan-

pan- approved these changes Mar 28, 2019

Copy link
Member

left a comment

@cmonr Looks good.

@cmonr cmonr added needs: CI and removed needs: review labels Mar 28, 2019

@jessexm
Copy link
Contributor

left a comment

Look good.

@GokhanBektasMaxim

This comment has been minimized.

Copy link

commented Mar 28, 2019

Looks good to me

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 29, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@adbridge adbridge added ready for merge and removed needs: CI labels Mar 29, 2019

@cmonr cmonr merged commit 1c35b95 into ARMmbed:master Mar 29, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9910 cycles (+490 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.