Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the presence of cmsis-pack-manager package optional #10089

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
6 participants
@bridadan
Copy link
Contributor

commented Mar 13, 2019

Description

Currently, the 5.12.0 release candidates do not build in 0.4.0 Mbed Studio. This patch will allow you to use the "active program tools" in 5.12.0 projects to build correctly. The issue is that Mbed Studio has limited Python environment that does not contain the cmsis-pack-manager Python package. Since we can't install this at this time for Mbed Studio, this make the package optional so you can still compile and use the local CMSIS Pack index.

FYI @SenRamakri @thegecko

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@bridadan bridadan requested a review from theotherjimmy Mar 13, 2019

@theotherjimmy

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

@arekzaluski Do you need this change for Studio?

@bridadan

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2019

@theotherjimmy thanks for bringing @arekzaluski into the loop.

Yeah if at all possible, this should be in the final release candidate for 5.12.0 if the current version of Mbed Studion (0.4.0) is to have any way of using 5.12.0.

@cmonr cmonr requested a review from ARMmbed/mbed-os-maintainers Mar 13, 2019

@cmonr

cmonr approved these changes Mar 14, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

Currently, the 5.12.0 release candidates do not build in 0.4.0 Mbed Studio.

That's unfortunate, but a pretty good reason to get this into RC3.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

CI started

@cmonr cmonr added needs: CI and removed needs: review labels Mar 14, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 14, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 14, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

The issue is that Mbed Studio has limited Python environment that does not contain the cmsis-pack-manager Python package. Since we can't install this at this time for Mbed Studio, this make the package optional so you can still compile and use the local CMSIS Pack index.

Does that mean the next studio version will contain a fix for this ?

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

@arekzaluski Do you need this change for Studio?

Please let us know. This can go to master at least now

@0xc0170 0xc0170 merged commit 0f2add7 into ARMmbed:master Mar 14, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10353 cycles (+933 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
@arekzaluski

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

@0xc0170 @bridadan @theotherjimmy Yes we need it, we will test it today in Mbed Studio. Thanks @bridadan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.