Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cinterion Cellular: Setup connection profile with username and password #10098

Merged
merged 1 commit into from Mar 18, 2019

Conversation

Projects
None yet
7 participants
@ghseb
Copy link

commented Mar 14, 2019

Description

According to the documentation Cinterion Modules like the ELS61 additionally to the APN require a username and a password to setup the Connection Profile.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Mar 14, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

@ghseb, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@cmonr

cmonr approved these changes Mar 15, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

@ARMmbed/mbed-os-maintainers I'm willing to consider tis as a fix.

@AriParkkila
Copy link
Contributor

left a comment

This PR is fine for default authentication. I'm guessing that authentication type (CHAP, PAP, ...) may need to be configurable sometimes, but it can be added when that's needed.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

@ARMmbed/mbed-os-maintainers I'm willing to consider tis as a fix.

It's target fix, LGTM

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 15, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 16, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 16, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 16, 2019

armclang: error: Failed to check out a license.

CI job restarted: jenkins-ci/exporter

@0xc0170 0xc0170 merged commit 964f5ad into ARMmbed:master Mar 18, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9168 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.