Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Support Cinterion EHS5-E cellular module #10100

Merged
merged 5 commits into from Mar 17, 2019

Conversation

Projects
None yet
6 participants
@ghseb
Copy link

commented Mar 14, 2019

Description

This PR aims to add basic support for the Cinterion EHS5-E cellular module.

Im not sure if i categorized the PR correctly.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

@ghseb, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Mar 14, 2019

@cmonr

cmonr approved these changes Mar 15, 2019

Copy link
Contributor

left a comment

👍

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

Im not sure if i categorized the PR correctly.

You're good.

{
// EHS5-E
static const intptr_t cellular_properties[AT_CellularBase::PROPERTY_MAX] = {
AT_CellularNetwork::RegistrationModeDisable, // C_GREG

This comment has been minimized.

Copy link
@AriParkkila

AriParkkila Mar 15, 2019

Contributor

This should probably be like below due to EHS5-E seems to be:

  • 2G/3G modem
  • With support for IPv4 and IPv6 but not for dual-stack
        AT_CellularNetwork::RegistrationModeDisable,    // C_EREG
        AT_CellularNetwork::RegistrationModeLAC,    // C_GREG
        AT_CellularNetwork::RegistrationModeLAC,    // C_REG
...
        1,  // PROPERTY_IPV4_STACK
        1,  // PROPERTY_IPV6_STACK
        0,  // PROPERTY_IPV4V6_STACK

This comment has been minimized.

Copy link
@ghseb

ghseb Mar 15, 2019

Author

You are right the registration modes need to be fixed. But i think the module does support dual stack mode

This comment has been minimized.

Copy link
@AriParkkila

AriParkkila Mar 15, 2019

Contributor

About dual-stack, according to ehs5-e_atc_v03001.pdf connection must be GPRS0 or GPRS6 and the current driver creates only one internet connection so it can't handle dual-stack yet.

This comment has been minimized.

Copy link
@ghseb

ghseb Mar 15, 2019

Author

Ok, im going to disable it.

This comment has been minimized.

Copy link
@AriParkkila

AriParkkila Mar 15, 2019

Contributor

@ghseb not for ModuleEMS31 :)

Sebastian Stockhammer added some commits Mar 15, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 16, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 16, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 16, 2019

cmonr added a commit to cmonr/mbed-os that referenced this pull request Mar 16, 2019

cmonr added a commit to cmonr/mbed-os that referenced this pull request Mar 16, 2019

Merge pull request ARMmbed#10100 from ghseb/support-ehs5-e
Cellular: Support Cinterion EHS5-E cellular module

@cmonr cmonr merged commit 05f18fc into ARMmbed:master Mar 17, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9005 cycles (-258 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 17, 2019

@ghseb ghseb deleted the ghseb:support-ehs5-e branch Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.