Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uhuru RAVEN: Adding platform HAL #10115

Merged
merged 4 commits into from Apr 4, 2019

Conversation

Projects
None yet
9 participants
@junichikatsu
Copy link
Contributor

commented Mar 15, 2019

Description

Uhuru RAVEN: Adding platform HAL

This pull request is a reissue of the next pull request. I made a branch and made a pull request.
#9787

Test results:
GCC
ARM
IAR

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from screamerbg and ARMmbed/mbed-os-maintainers Mar 15, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

travis tool jobs are failing with message : AssertionError: Target UHURU_RAVEN contains invalid device_name STM32F767VI . Please review

@0xc0170 0xc0170 added needs: work and removed needs: review labels Mar 15, 2019

@0xc0170
Copy link
Member

left a comment

Small changes request, looks fine to me otherwise

* FUNCTION PROTOTYPES
* ----------------------------------------------------------------*/

void uhuru_raven_init(void);

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Mar 15, 2019

Member

would be good to document this function here - what this function should do.

This comment has been minimized.

Copy link
@junichikatsu

junichikatsu Mar 18, 2019

Author Contributor

added the description of uhuru_raven_init function

@@ -0,0 +1,260 @@
/* mbed Microcontroller Library
* Copyright (c) 2006-2019 ARM Limited

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Mar 15, 2019

Member

Please add SPDX identifiers for new files (PDX-License-Identifier: Apache-2.0) or BSD 3 clause for others

This comment has been minimized.

Copy link
@junichikatsu

junichikatsu Mar 18, 2019

Author Contributor

added SPDX identifier

@cmonr cmonr self-requested a review Mar 15, 2019

@junichikatsu

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

@0xc0170

travis tool jobs are failing with message : AssertionError: Target UHURU_RAVEN contains invalid device_name STM32F767VI . Please review

fixed and all travis tool jobs passed.

@0xc0170 0xc0170 requested a review from ashok-rao Mar 18, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

Thanks for the update, LGTM

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

CI started whilst reviews are completed

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 18, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

armclang: error: Failed to check out a license.

CI job restarted: jenkins-ci/mbed-os-ci_exporter

#include "stm32f7xx.h"
#include "nvic_addr.h"
#include "mbed_error.h"
#if TARGET_UHURU_RAVEN

This comment has been minimized.

Copy link
@cmonr

cmonr Mar 19, 2019

Contributor

I might be missing something, but why is this needed if this file is inside of its own TARGET subdir?

@cmonr

cmonr approved these changes Mar 19, 2019

Copy link
Contributor

left a comment

LGTM

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 19, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

@ashok-rao please review

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@cmonr cmonr added the needs: work label Mar 27, 2019

@cmonr cmonr removed the needs: review label Mar 27, 2019

@junichikatsu

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

@cmonr
I'm sorry.
I'll go back with the commit and then rebase.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@junichikatsu Thank you! I know it takes a bit of getting use to (I recall having a hard time with it when I started), but there are decent technical reasons why rebases are prefered in this repo.

@junichikatsu junichikatsu force-pushed the enebular:raven branch from 5027704 to 40efb1d Mar 27, 2019

junichikatsu added some commits Mar 14, 2019

added SPDX identifier and
added the description of uhuru_raven_init function

@junichikatsu junichikatsu force-pushed the enebular:raven branch from 40efb1d to cc6c477 Mar 27, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@screamerbg @ARMmbed/mbed-os-storage could we get a review on this please?

@davidsaada
Copy link
Contributor

left a comment

LGTM, other than the redundant TARGET_UHURU_RAVEN ifdef, (addressed by @cmonr's), which is not a blocker anyway.

@toyowata

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

@adbridge Hi. I believe @screamerbg is on holiday this week. Can you assign someone in TAM if you need more reviewer? e.g. @ashok-rao or @MarceloSalazar

"config": {
"clock_source": {
"help": "Mask value : USE_PLL_HSE_EXTC | USE_PLL_HSE_XTAL | USE_PLL_HSI",
"value": "USE_PLL_HSE_XTAL",

This comment has been minimized.

Copy link
@ashok-rao

ashok-rao Apr 3, 2019

Contributor

What is the XTAL frequency used here?

This comment has been minimized.

Copy link
@junichikatsu

junichikatsu Apr 3, 2019

Author Contributor

It used 8MHz XTAL.

@ashok-rao

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

Small comment, otherwise looks good to me.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Apr 3, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 3, 2019

Test run: FAILED

Summary: 1 of 1 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests
@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

CI restarted (internal error)

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 3, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 4, 2019

@0xc0170 0xc0170 merged commit 6081727 into ARMmbed:master Apr 4, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10019 cycles (-229 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.