Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Fix network interface test for cellular targets #10120

Merged

Conversation

Projects
None yet
8 participants
@mirelachirica
Copy link
Contributor

commented Mar 15, 2019

Description

Test's status_cb() can ignore cellular specific events because the values they are delivering are not connection statuses. Cellular connection statuses are still delivered with
NSAPI_EVENT_CONNECTION_STATUS_CHANGE events.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Mar 15, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

@mirelachirica mirelachirica force-pushed the mirelachirica:networkinterface_connection_status_fix branch Mar 15, 2019

@mirelachirica

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2019

Pushed astyle fix

Show resolved Hide resolved TESTS/network/interface/networkinterface_status.cpp Outdated

@0xc0170 0xc0170 added needs: work and removed needs: review labels Mar 15, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

Pull request type

Don't let the type empty, please fix

@mirelachirica mirelachirica force-pushed the mirelachirica:networkinterface_connection_status_fix branch to d15bcfe Mar 15, 2019

@cmonr cmonr requested a review from SeppoTakalo Mar 15, 2019

@0xc0170 0xc0170 removed the request for review from ARMmbed/mbed-os-test Mar 19, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 19, 2019

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

Starting CI

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 20, 2019

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 20, 2019

@0xc0170 0xc0170 merged commit 0d86248 into ARMmbed:master Mar 20, 2019

21 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/greentea-test Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10316 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.