Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add baremetal example to testing #10131

Merged
merged 2 commits into from Mar 27, 2019

Conversation

Projects
None yet
@kegilbert
Copy link
Contributor

commented Mar 17, 2019

Description

Add a basic baremetal blinky example to the test framework to get a smoketest of baremetal (currently have none in CI). @bulislaw Does this look like a more reasonable solution than modifying blinky?

@cmonr Should bare-metal be in 5.11.5? It was merged a couple of weeks before that release branch was made but I don't see it in there. I can either remove the bare-metal build profile from the example until the example is updated to 5.12 or point to a RC branch for the example's mbed-os hash. I wasn't 100% on the examples policy on what we can point to.
See Martin's reply: #10131 (comment)

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@bulislaw @SenRamakri

Release Notes

@kegilbert kegilbert force-pushed the kegilbert:baremetal-blinky-examples-test branch Mar 17, 2019

@ciarmcom ciarmcom requested review from bulislaw, SenRamakri and ARMmbed/mbed-os-maintainers Mar 17, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 17, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

Baremetal is part of 5.12.
Point to mbed-os-5.12 branch now.

One note about naming - shouldn't be baremetal as suffix (blinky-baremetal) rather?

@kegilbert kegilbert force-pushed the kegilbert:baremetal-blinky-examples-test branch Mar 18, 2019

@kegilbert

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

@0xc0170 Updated the example names and pointed to the Mbed OS 5.12 branch.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

CI started

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

@kegilbert Plz fix, k thx.

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 18, 2019

Test run: FAILED

Summary: 4 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARMC5
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR8
  • jenkins-ci/mbed-os-ci_build-ARMC6

@kegilbert kegilbert force-pushed the kegilbert:baremetal-blinky-examples-test branch to 288d339 Mar 18, 2019

@kegilbert

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

@cmonr Limited the list of targets to ignore boards that are not built for Mbed OS 2 (mainly targets that were pulling in WifiInterface files that required RTOS classes).

@cmonr

cmonr approved these changes Mar 18, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 19, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

CI job restarted: jenkins-ci/mbed-os-ci_exporter

Hate it when an exporter job fails because the JVM threw a fit (gnuarmeclipse ide).

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

Exporters restarted again

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

Exporters failing for multiple boards and 2nd time, please review

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Mar 19, 2019

@bulislaw
Copy link
Member

left a comment

That's confusing. Well not these changes but the new example. There's not explanation what it illustrates and why is it there. We should at least add a description for external users saying what does it do and what's bare metal (with link to docs).

@kegilbert

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2019

I'm touching up some of the baremetal/migration guide docs. I'm planning on adding a blurb there pointing to this is an out of the box baremetal example.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

@kegilbert You might need to take a look at the failure logs.

There might be problem with the PR/targets after all:
https://mbed-os.mbedcloudtesting.com/blue/rest/organizations/jenkins/pipelines/mbed-os-ci_exporter-gnuarmeclipse/runs/1787/nodes/46/log/?start=0

@kegilbert

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2019

Don't seem to have access to that link @cmonr.
https://mbed-os.mbedcloudtesting.com/blue/organizations/jenkins/mbed-os-ci_exporter/detail/mbed-os-ci_exporter/1585/pipeline/17 isn't giving me much info, is there another link I could use?

@theotherjimmy

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

@kegilbert I'm not sure that I can fix this in a short order, because I don't know how I would fix this. I would expect this to take > 1day of work (which is all we have left before RC4)

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

Proposed path forward is to remove gnuarmeclipse testing for this example

It has not been updated, neither any PR referencing this one. This might not be in rc4 if it does not get an update within next few hours.

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

@kegilbert @theotherjimmy Could you not just add the list of exporters that do work to the exporters list in examples.json ? Though that would obviously only help our internal testing.

@kegilbert BTW you will need to talk to @screamerbg to get this example mirrored to os.mbed.com.....

Remove gnuarmeclipse from baremetal export testing
baremetal does not currently work with gnuarmeclipse
@kegilbert

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

Apologies for the delay, updated the exporter list and updated the OS teams example @adbridge
https://os.mbed.com/teams/mbed-os-examples/code/mbed-os-example-blinky-baremetal

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Mar 22, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 22, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@adbridge

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

@kegilbert still failing exporters by the looks of it :(

@adbridge adbridge added needs: work and removed needs: CI labels Mar 22, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

Bumping this out to 5.12.1

@kegilbert

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

It's failing for uvision6 on the LPC55S69_NS, which is not a target included in my list for the baremetal example. Any idea why that one would be failing?

@bridadan

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

Oh hey that target is failing on my PR as well: #10193

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

CI restarted.
Complete restart needed since master's HEAD has moved, meaning CI needs to run against a new /ref/pull/*/merge reference

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 26, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 5
Build artifacts

cmonr added a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019

Merge pull request ARMmbed#10131 from kegilbert/baremetal-blinky-exam…
…ples-test

Add baremetal example to testing

@cmonr cmonr merged commit c2e5a8b into ARMmbed:master Mar 27, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9171 cycles (-1216 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.