Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding STM32_F439 as a new MTB target #10133

Merged
merged 2 commits into from Mar 20, 2019

Conversation

Projects
None yet
6 participants
@ashok-rao
Copy link
Contributor

commented Mar 17, 2019

Description

Adding STM32_F439 MCU only (on a Module Carrier Board) as a new MTB target. This will be used as a base MCU for upcoming cellular MODEMs and other connectivity Module Expansion Boards (MEB).

Greentea logs attached below:
MTB_STM32_F439_GT_Logs_ARMCC_Pass.txt
MTB_STM32_F439_GT_Logs_GCC_Pass.txt
MTB_STM32_F439_GT_Logs_IAR_Pass.txt

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@0xc0170 @jeromecoutant @cmonr

Release Notes

@ciarmcom ciarmcom requested review from 0xc0170, cmonr, screamerbg and ARMmbed/mbed-os-maintainers Mar 17, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 17, 2019

@ashok-rao, thank you for your changes.
@cmonr @0xc0170 @screamerbg @ARMmbed/mbed-os-maintainers please review.

@ashok-rao

This comment has been minimized.

Copy link
Contributor Author

commented Mar 17, 2019

Quick note: For GT tests, I've used IAR 8.32.1 & ARMC5.

@0xc0170
Copy link
Member

left a comment

ARMC5 - had your own config to override it ? This target would support ARCM6 by default (inherits it).

@jeromecoutant

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

Maybe description needs to be updated: "Adding STM32_L475" ?

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

Maybe description needs to be updated: "Adding STM32_L475" ?

Files are being added to TARGET_STM32F439xI/TARGET_MTB_STM32_F439 and all its references. But the comment above is STM32_L475 - good catch. @ashok-rao Please confirm

@ashok-rao

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

@jeromecoutant @0xc0170 : Description error, now corrected. Thanks, good catch!

@ashok-rao

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

@jeromecoutant : General question on clock configuration, do you use STM32CubeMX to generate the clock configs or are these done manually for each of the targets?

@jeromecoutant

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

do you use STM32CubeMX to generate the clock configs or are these done manually for each of the targets?

Yes, I am using CubeMX tool to check if there are no "red" values for all prescalers values.
I am also using CubeMx to build the peripheral pins files (see #9394)

Removing redundant code.
MCO pins are not brought out on MTB / MCB design.
@ashok-rao

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

  • Review comments incorporated.
  • Adding GT logs for ARMC6

MTB_STM32_F439_GT_Logs_ARMC6_Pass.txt

@cmonr

cmonr approved these changes Mar 19, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 19, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 19, 2019

@0xc0170 0xc0170 merged commit 7d853b4 into ARMmbed:master Mar 20, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9980 cycles (-349 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.