Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanostack 802.15.4 RF drivers update #10142

Merged

Conversation

Projects
None yet
10 participants
@artokin
Copy link
Contributor

commented Mar 18, 2019

Description

Sync Nanostack RF drivers from master copies:
-Atmel: v3.0.7
-MCR20A: v1.0.3
-S2LP: v0.0.4

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@JarkkoPaso

Nanostack 802.15.4 RF drivers update
Sync Nanostack RF drivers from master copies:
-Atmel: v3.0.7
-MCR20A: v1.0.3
-S2LP: v0.0.4

@ciarmcom ciarmcom requested review from JarkkoPaso and ARMmbed/mbed-os-maintainers Mar 18, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

@artokin, thank you for your changes.
@JarkkoPaso @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

This driver is used with 6LoWPAN and Wi-SUN stacks.

Driver is tested with X-Nucleo-S2868A1 RF expansion board. https://www.st.com/en/ecosystems/x-nucleo-s2868a1.html

This comment has been minimized.

Copy link
@VeijoPesonen

VeijoPesonen Mar 18, 2019

Contributor

Could be turned into a link for readability - X-NUCLEO-S2868A1

This comment has been minimized.

Copy link
@artokin

artokin Mar 18, 2019

Author Contributor

OK, we will keep that in mind when updating the readme next time.

Driver is tested with X-Nucleo-S2868A1 RF expansion board. https://www.st.com/en/ecosystems/x-nucleo-s2868a1.html

NOTE: Default SPI SCLK pin configuration is D13. On X-Nucleo-S2868A1, resistor R6 must be soldered instead of R11. For more information, see user manual UM2405. https://www.st.com/resource/en/user_manual/dm00498153.pdf

This comment has been minimized.

Copy link
@VeijoPesonen

VeijoPesonen Mar 18, 2019

Contributor

Could be turned into a link for readability - UM2405 User manual

This comment has been minimized.

Copy link
@artokin

artokin Mar 18, 2019

Author Contributor

OK, we will keep that in mind when updating the readme next time.

@cmonr

cmonr approved these changes Mar 19, 2019

@cmonr cmonr added needs: CI and removed needs: review labels Mar 19, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

@artokin Making sure, this can come into 5.12.1 instead of 5.12.0-rc3, correct?

CC @ARMmbed/mbed-os-maintainers

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 19, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@artokin

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2019

@cmonr , 5.12.1 is fine for this update.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

CI job restarted: jenkins-ci/mbed-os-ci_exporter

Failures don't immediately appear to be related to PR.

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

CI Has passed.
@JarkkoPaso would you still like to review this before merge?

@JarkkoPaso

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

Looks good to me.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 20, 2019

@0xc0170 0xc0170 merged commit 6da5f9b into ARMmbed:master Mar 20, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10001 cycles (-328 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@artokin artokin deleted the artokin:nanostack_rf_drivers_interrruptin_flag branch Mar 21, 2019

@@ -15,7 +15,7 @@
*/
#include "NanostackRfPhyMcr20a.h"

This comment has been minimized.

Copy link
@jeromecoutant

jeromecoutant Mar 21, 2019

Contributor

Hi
This include should be 3 lines below... after the #if check

This comment has been minimized.

Copy link
@cmonr

cmonr Mar 25, 2019

Contributor

Making a note.

Fixed in #10185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.