Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTB_STM_L475: fix UART clock #10156

Merged
merged 1 commit into from Mar 21, 2019

Conversation

Projects
None yet
6 participants
@juhoeskeli
Copy link
Contributor

commented Mar 19, 2019

Description

Fix UART communications for MTB_STM_L475 by adjusting the UART system clock. Tested with various modem shields using the MCU. Without the change the MCU to modem communications will be corrupted.

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ashok-rao

Release Notes

@ashok-rao

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

@0xc0170 : I have also validated this change with: https://github.com/ARMmbed/reference-design-RD2166

@ciarmcom ciarmcom requested review from ashok-rao, screamerbg and ARMmbed/mbed-os-maintainers Mar 19, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

@juhoeskeli, thank you for your changes.
@ashok-rao @screamerbg @ARMmbed/mbed-os-maintainers please review.

@ashok-rao
Copy link
Contributor

left a comment

LGTM! Thanks @juhoeskeli

@@ -200,6 +201,7 @@ uint8_t SetSysClock_PLL_HSE(uint8_t bypass)
return 0; // FAIL
}

#if 0

This comment has been minimized.

Copy link
@cmonr

cmonr Mar 19, 2019

Contributor

What's the reason for leaving this block of code in if it's never going to be run?

This comment has been minimized.

Copy link
@juhoeskeli

juhoeskeli Mar 20, 2019

Author Contributor

No reason. I'll take it out.

Juho Eskeli
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

CI started

@cmonr

cmonr approved these changes Mar 20, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 20, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 20, 2019

@0xc0170 0xc0170 merged commit d850d3b into ARMmbed:master Mar 21, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9947 cycles (-108 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@juhoeskeli juhoeskeli deleted the juhoeskeli:MTB_STM_L475_uart_clock_fix branch Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.