Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto access control additional tests #10160

Merged

Conversation

Projects
None yet
6 participants
@itayzafrir
Copy link
Contributor

commented Mar 19, 2019

Description

Additional tests for crypto access control

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

@itayzafrir, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Mar 19, 2019

@orenc17

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

i think you should move the buffers outside of the functions, just to avoid stack issues

@itayzafrir

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

@orenc17

i think you should move the buffers outside of the functions, just to avoid stack issues

these are static const arrays, not on the stack

@itayzafrir

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

@avolinski please review

@cmonr cmonr requested a review from avolinski Mar 20, 2019

itayzafrir
@moranpeker
Copy link
Contributor

left a comment

LGTM

@cmonr

cmonr approved these changes Mar 27, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

CI started

@cmonr cmonr added needs: CI and removed needs: review labels Mar 27, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 27, 2019

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 27, 2019

@@ -473,22 +565,26 @@ utest::v1::status_t test_setup(const size_t number_of_cases)
}

Case cases[] = {
Case("open other partitions' key",
Case("open other partition's key",

This comment has been minimized.

Copy link
@cmonr

cmonr Mar 27, 2019

Contributor

😀

@cmonr cmonr merged commit 1549c5c into ARMmbed:master Mar 27, 2019

21 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/greentea-test Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9122 cycles (+23 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.