Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cypress boards from CMSIS pack manager #10186

Merged
merged 4 commits into from Mar 21, 2019
Merged

Remove cypress boards from CMSIS pack manager #10186

merged 4 commits into from Mar 21, 2019

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented Mar 21, 2019

Description

Remove cypress boards from CMSIS pack manager as the values were fabricated and are no longer necessary. (@dannybenor can confirm that)

This fixes #10183

depending on:

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@theotherjimmy @ARMmbed/team-cypress

Release Notes

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 21, 2019

Ci started

@theotherjimmy
Copy link
Contributor

@orenc17 This looks like a manual modification. Please refrain from doing such manual modifications as they can easily be klobered next time we regenerate index.json.

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These things seem fishy to me, further indicating that this was a manual modification that will be clobbered when we next update the index.

"IRAM1": {
"access": {
"execute": true,
"non_secure": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This permission bit is reserved for v8m platforms when I last checked, and will have no affect for v7m or v6m platforms.

},
"IRAM1": {
"access": {
"execute": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read, write and execute for a RAM? that sounds incorrect to me.

@orenc17 orenc17 changed the title Add RAM regions for cypress platforms Remove cypress boards from CMSIS pack manager Mar 21, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 21, 2019

CI aborted, will be restarted

@mbed-ci
Copy link

mbed-ci commented Mar 21, 2019

Test run: FAILED

Summary: 5 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARMC6
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR8
  • jenkins-ci/mbed-os-ci_mbed2-build-ARMC5
  • jenkins-ci/mbed-os-ci_build-ARMC5

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 21, 2019

CI resrtarted

@orenc17
Copy link
Contributor Author

orenc17 commented Mar 21, 2019

do not merge for now, as this breaks BL
@theotherjimmy is working on a fix i'll need to rebase on

@orenc17
Copy link
Contributor Author

orenc17 commented Mar 21, 2019

@ARMmbed/mbed-os-maintainers this one is ready
still waiting for the dependencies

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 21, 2019

CI aborted, rollup in

@mbed-ci
Copy link

mbed-ci commented Mar 21, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@0xc0170 0xc0170 merged commit 6f7f30f into ARMmbed:master Mar 21, 2019
@0xc0170 0xc0170 removed the needs: CI label Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mbed_ram_start/size is not sent to CY8CKIT_062_WIFI_BT_PSA
5 participants