Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cypress boards from CMSIS pack manager #10186

Merged
merged 4 commits into from Mar 21, 2019

Conversation

Projects
None yet
5 participants
@orenc17
Copy link
Contributor

commented Mar 21, 2019

Description

Remove cypress boards from CMSIS pack manager as the values were fabricated and are no longer necessary. (@dannybenor can confirm that)

This fixes #10183

depending on:

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@theotherjimmy @ARMmbed/team-cypress

Release Notes

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

Ci started

@theotherjimmy

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

@orenc17 This looks like a manual modification. Please refrain from doing such manual modifications as they can easily be klobered next time we regenerate index.json.

@theotherjimmy
Copy link
Contributor

left a comment

These things seem fishy to me, further indicating that this was a manual modification that will be clobbered when we next update the index.

"IRAM1": {
"access": {
"execute": true,
"non_secure": true,

This comment has been minimized.

Copy link
@theotherjimmy

theotherjimmy Mar 21, 2019

Contributor

This permission bit is reserved for v8m platforms when I last checked, and will have no affect for v7m or v6m platforms.

},
"IRAM1": {
"access": {
"execute": true,

This comment has been minimized.

Copy link
@theotherjimmy

theotherjimmy Mar 21, 2019

Contributor

Read, write and execute for a RAM? that sounds incorrect to me.

@orenc17 orenc17 changed the title Add RAM regions for cypress platforms Remove cypress boards from CMSIS pack manager Mar 21, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

CI aborted, will be restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 21, 2019

Test run: FAILED

Summary: 5 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARMC6
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR8
  • jenkins-ci/mbed-os-ci_mbed2-build-ARMC5
  • jenkins-ci/mbed-os-ci_build-ARMC5
@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

CI resrtarted

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

do not merge for now, as this breaks BL
@theotherjimmy is working on a fix i'll need to rebase on

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Mar 21, 2019

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

@ARMmbed/mbed-os-maintainers this one is ready
still waiting for the dependencies

@orenc17 orenc17 referenced this pull request Mar 21, 2019

Merged

Rollup #10189

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

CI aborted, rollup in

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 21, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@0xc0170 0xc0170 merged commit 6f7f30f into ARMmbed:master Mar 21, 2019

14 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9147 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.