New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cypress boards from CMSIS pack manager #10186
Conversation
Ci started |
@orenc17 This looks like a manual modification. Please refrain from doing such manual modifications as they can easily be klobered next time we regenerate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These things seem fishy to me, further indicating that this was a manual modification that will be clobbered when we next update the index.
tools/arm_pack_manager/index.json
Outdated
"IRAM1": { | ||
"access": { | ||
"execute": true, | ||
"non_secure": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This permission bit is reserved for v8m platforms when I last checked, and will have no affect for v7m or v6m platforms.
tools/arm_pack_manager/index.json
Outdated
}, | ||
"IRAM1": { | ||
"access": { | ||
"execute": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read, write and execute for a RAM? that sounds incorrect to me.
CI aborted, will be restarted |
Test run: FAILEDSummary: 5 of 9 test jobs failed Failed test jobs:
|
CI resrtarted |
do not merge for now, as this breaks BL |
@ARMmbed/mbed-os-maintainers this one is ready |
CI aborted, rollup in |
Test run: FAILEDSummary: 1 of 13 test jobs failed Failed test jobs:
|
Description
Remove cypress boards from CMSIS pack manager as the values were fabricated and are no longer necessary. (@dannybenor can confirm that)
This fixes #10183
depending on:
targets.json
#10188Pull request type
Reviewers
@theotherjimmy @ARMmbed/team-cypress
Release Notes