Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the removal of Mbed-added core flags in uvision exporter #10199

Merged
merged 1 commit into from Mar 23, 2019

Conversation

Projects
None yet
6 participants
@bridadan
Copy link
Contributor

commented Mar 22, 2019

Description

Fixes the exporter CI issue that started cropping up on recent PRs (#10193, #10131).

The extra flags that we add to the core name in Mbed were not being stripped correctly. This caused the LPC55S69_NS target to not build in Uvision.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@bridadan bridadan requested a review from theotherjimmy Mar 22, 2019

@bridadan bridadan referenced this pull request Mar 22, 2019

Merged

Fallback to ARMC5 when ARMC6 is not configured #10193

1 of 1 task complete
@NirSonnenschein
Copy link
Contributor

left a comment

LGTM

@theotherjimmy
Copy link
Contributor

left a comment

Great. Jira ticket to make this (and the one in tools/export/cmsis/__init__.py) not such a kludge?

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

ci started

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

restarted exporter to see if failure was sporadic:
23:14:20 23:14:20 [LPC55S69_NS:uvision6] Error: hudson.AbortException: script returned exit code 2
license issue?
there is also : C:\Users\ADMINI~1\AppData\Local\Temp\p544-3: Error: L6366E: ./mbed-os/targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_LPC55S69/device/TOOLCHAIN_ARMC6/lib_power.ar(fsl_power_lib.o) attributes are not compatible with the provided attributes .
@bridadan , please take a look when you can

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 22, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@ARMmbed ARMmbed deleted a comment from 0xc0170 Mar 23, 2019

@ARMmbed ARMmbed deleted a comment from 0xc0170 Mar 23, 2019

@bridadan bridadan force-pushed the bridadan:fix_cores_in_uvision branch from 97892aa to f56bf8f Mar 23, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2019

ci restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 23, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr merged commit 4e514ae into ARMmbed:master Mar 23, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9141 cycles (+9 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Mar 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.