Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vscode default gcc arm version to 6-2017-q1-update #10200

Merged
merged 1 commit into from Mar 29, 2019

Conversation

Projects
None yet
7 participants
@studavekar
Copy link
Contributor

commented Mar 22, 2019

Description

When we export a project for vscode, launch.json on windows gets populated with older version of gcc_arm

"MIDebuggerPath": "C:\\Program Files (x86)\\GNU Tools ARM Embedded\\4.9 2015q3\\bin\\arm-none-eabi-gdb.exe",

Default template point to an older version of gcc arm. updating the template to officially supported version of gcc arm 6-2017-q1-update

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@theotherjimmy @bridadan @TacoGrandeTX

@theotherjimmy theotherjimmy changed the title update gcc arm version to 6-2017-q1-update update vscode default gcc arm version to 6-2017-q1-update Mar 22, 2019

@theotherjimmy

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

@studavekar Please be more specific with your pull request titles in the future. I almost thought you had resubmitted an old PR.

@theotherjimmy
Copy link
Contributor

left a comment

I don't like that we must have a default that's super specific like this

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

@janjongboom Mind taking a quick look at this since you use VSCode?

@bridadan

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

I don't like that we must have a default that's super specific like this

Oh jeez, yeah this isn't ideal. Is it possible to use whatever is found in the system PATH instead?

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

@bridadan It's not guaranteed that GCC will be an env var set in Windows.
I suppose it depends on how the user installed GCC.

@bridadan

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

@bridadan It's not guaranteed that GCC will be an env var set in Windows.
I suppose it depends on how the user installed GCC.

Very true. However it seems to me a more reasonable assumption than the exact installation path of the tool.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@studavekar Thoughts?

@studavekar

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

@studavekar Thoughts?

From the above discussion, it sounds like a reasonable assumption. Docs also mention of having an absolute path in config https://os.mbed.com/docs/mbed-os/v5.12/tutorials/visual-studio-code.html#configuring-the-debugger

@bridadan

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

To be clear, I'm not asking for changes in this PR :) Looks fine how it is, but it may be worthwhile to investigate in the future.

@studavekar

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

To be clear, I'm not asking for changes in this PR :) Looks fine how it is, but it may be worthwhile to investigate in the future.

Have created an issue #10255 for future investigation.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

To be clear, I'm not asking for changes in this PR

Oh. Thanks for that clarification 😁

@cmonr

cmonr approved these changes Mar 28, 2019

@cmonr cmonr added needs: CI and removed needs: review labels Mar 28, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 29, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
@alekla01

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

restarted jenkins-ci/mbed-os-ci_greentea-test

@adbridge adbridge added ready for merge and removed needs: CI labels Mar 29, 2019

@cmonr cmonr merged commit 0a088a6 into ARMmbed:master Mar 29, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10358 cycles (-29 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.