Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuvoton: Add button names BUTTON1/BUTTON2 #10209

Merged
merged 1 commit into from Mar 27, 2019

Conversation

Projects
None yet
5 participants
@ccli8
Copy link
Contributor

commented Mar 25, 2019

Description

This PR adds button name definitions BUTTON1/BUTTON2 for Nuvoton targets:

  • NUMAKER_PFM_NANO130
  • NUMAKER_PFM_NUC472
  • NUMAKER_PFM_M453
  • NUMAKER_PFM_M487/NUMAKER_IOT_M487
  • NUMAKER_PFM_M2351

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

@ccli8, thank you for your changes.
@Ronny-Liu @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from Ronny-Liu and ARMmbed/mbed-os-maintainers Mar 25, 2019

@cmonr

cmonr approved these changes Mar 25, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

Waiting on #10221 for astyle fix.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

Hmm... The astyle fix is missing this fix: #10222

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

please re-base when you have time, it should resolve the astyle issue

@ccli8 ccli8 force-pushed the OpenNuvoton:nuvoton_add-button-name branch from 45d04fb to be96ade Mar 26, 2019

@ccli8

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

@NirSonnenschein Rebase done

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

CI started

cmonr added a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019

Merge pull request ARMmbed#10209 from OpenNuvoton/nuvoton_add-button-…
…name

Nuvoton: Add button names BUTTON1/BUTTON2
@mbed-ci

This comment has been minimized.

Copy link

commented Mar 26, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 26, 2019

@cmonr cmonr merged commit be38d95 into ARMmbed:master Mar 27, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10480 cycles (+1354 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 27, 2019

@ccli8 ccli8 deleted the OpenNuvoton:nuvoton_add-button-name branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.