Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tempsensor cal1 constant in stm32f3xx_ll_adc.h #10212

Merged
merged 1 commit into from Mar 28, 2019

Conversation

Projects
None yet
6 participants
@ecoromka
Copy link
Contributor

commented Mar 25, 2019

Description

Fix of TEMPSENSOR_CAL1_TEMP constant for F3 series targets.

Datasheet says it is 30. This leads to an error in internal temperature readings, using provided macro.

Datasheet, page 150/173, Table 90: https://www.st.com/resource/en/datasheet/stm32f303re.pdf
Same for all MCU, mentioned in correspondig file (STM32F301x8 || STM32F302x8 || STM32F302xC || STM32F302xE || STM32F303x8 || STM32F303xC || STM32F303xE || STM32F318xx || STM32F328xx || STM32F334x8 || STM32F358xx || STM32F398xx).

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jeromecoutant

Release Notes

@ecoromka ecoromka closed this Mar 25, 2019

@ecoromka ecoromka reopened this Mar 25, 2019

@ecoromka ecoromka closed this Mar 25, 2019

@ecoromka ecoromka reopened this Mar 25, 2019

@ecoromka

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

It's the first time i'm making a pull request. I've tried to follow the rules, please indicate if anything wrong.

@ciarmcom ciarmcom requested review from screamerbg and ARMmbed/mbed-os-maintainers Mar 25, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

@ecoromka, thank you for your changes.
@screamerbg @ARMmbed/mbed-os-maintainers please review.

@ecoromka

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

Oh, it corresponds to an issue: #10203

@ecoromka

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

Should I edit the code to match travis astyle suggestions in order to pass the check? I'm confused 'cause I only changed "25" to "30".

If I make those stlye changes, how do I restart the check? New commit and new pull request?

Thank you!

@jeromecoutant

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

@ARMmbed/mbed-os-maintainers There should not be any astyle check in this directory

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

@jeromecoutant Correct, that's my bad.

Waiting on #10221 for astyle fix.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

@ecoromka No change needed on your side for now. Will let you know if that changes.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

Info: This PR has now been rebased.

If this was made in error, feel free to force-push your local branch to restore the PR.

@cmonr cmonr force-pushed the ecoromka:master branch from 063c861 to 19c271e Mar 26, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

@ecoromka In the future, you can also open a pull request directly from a branch as well.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

Hmm... The astyle fix is missing this fix: #10222

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

please re-base when you have time, it should resolve the astyle issue

Fix tempsensor cal1 constant in stm32f3xx_ll_adc.h
Fix TEMPSENSOR_CAL1_TEMP according to datasheet.

@cmonr cmonr force-pushed the ecoromka:master branch from 19c271e to 757b9e2 Mar 26, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

Info: This PR has now been rebased.

If this was made in error, feel free to force-push your local branch to restore the PR.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

CI started

cmonr added a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019

Merge pull request ARMmbed#10212 from ecoromka/master
 Fix tempsensor cal1 constant in stm32f3xx_ll_adc.h
@mbed-ci

This comment has been minimized.

Copy link

commented Mar 26, 2019

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

No idea why GCC_ARM failed for a completely unrelated target.

Restarted job, but may need to restart entire pipeline.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

Pipeline it is.

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 27, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@screamerbg would you still like to review this before it is merged (tiny PR)?

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 27, 2019

cmonr added a commit to cmonr/mbed-os that referenced this pull request Mar 28, 2019

Merge pull request ARMmbed#10212 from ecoromka/master
 Fix tempsensor cal1 constant in stm32f3xx_ll_adc.h

@cmonr cmonr merged commit 6443e43 into ARMmbed:master Mar 28, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10256 cycles (+1157 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.