Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI: Updated astyle to work with updated .astyleignore file #10222

Merged
merged 1 commit into from Mar 26, 2019

Conversation

Projects
None yet
3 participants
@cmonr
Copy link
Contributor

commented Mar 26, 2019

Description

Switches astyle command to use grep instead of fgrep. (fgrep === grep -F).

Strings passed into grep with fgrep are treated as plain text, whereas now, we want to match the start of strings.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

Updated astyle to work with updated .astyleignore file
fgrep === grep -F
-F treats lines as fixed strings (aka, the '^' isn't expanded)

@cmonr cmonr added the needs: CI label Mar 26, 2019

@cmonr cmonr requested a review from ARMmbed/mbed-os-maintainers Mar 26, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

CI started

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

@cmonr, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@cmonr

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

Proof that the fix works this time around...
cmonr#43

@cmonr cmonr referenced this pull request Mar 26, 2019

Merged

PSA - TFM manfiest scan #10218

@NirSonnenschein NirSonnenschein merged commit f1e664b into ARMmbed:master Mar 26, 2019

15 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10286 cycles (-29 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.