Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanostack ARMC6 update #10231

Merged
merged 2 commits into from Mar 28, 2019

Conversation

Projects
None yet
7 participants
@artokin
Copy link
Contributor

commented Mar 26, 2019

Description

  • Update coap-service from master repository
  • Fix few compiler warnings from Nanostack HAL

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@JarkkoPaso , @mikter , @deepakvenugopal

artokin added some commits Mar 26, 2019

Squashed 'features/nanostack/coap-service/' changes from 227cc3d..086…
…e7ba

086e7ba Adjust variable scope (#121)

git-subtree-dir: features/nanostack/coap-service
git-subtree-split: 086e7ba8a1afdcfe3df16ae92ef28cae1af5a4a6
Fix compiler warnings in Nanostack HAL
Fix compiler warnings:
 -"warning: 'size' argument to memset is '0'"
 -"warning: implicit declaration of function"

@ciarmcom ciarmcom requested review from deepakvenugopal, JarkkoPaso, mikter and ARMmbed/mbed-os-maintainers Mar 26, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

@cmonr

cmonr approved these changes Mar 26, 2019

@@ -70,7 +71,7 @@ static fhss_timeout_s *allocate_timeout(void)
{
for (int i = 0; i < NUMBER_OF_SIMULTANEOUS_TIMEOUTS; i++) {
if (fhss_timeout[i].fhss_timer_callback == NULL) {
memset(&fhss_timeout[i], sizeof(fhss_timeout_s), 0);
memset(&fhss_timeout[i], 0, sizeof(fhss_timeout_s));

This comment has been minimized.

Copy link
@cmonr

cmonr Mar 26, 2019

Contributor

👀

@@ -19,6 +19,12 @@

#include "mbedtls/entropy_poll.h"

#ifdef MBEDTLS_ENTROPY_HARDWARE_ALT

This comment has been minimized.

Copy link
@cmonr

cmonr Mar 26, 2019

Contributor

Feels weird to have both an ifdef and if defined in the same line.

This comment has been minimized.

Copy link
@cmonr

cmonr Mar 26, 2019

Contributor

Won't hold this up on that nit tho.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 28, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added the needs: review label Mar 28, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

@ARMmbed/mbed-os-mesh Any thoughts?

@cmonr cmonr removed the needs: CI label Mar 28, 2019

@mikter

mikter approved these changes Mar 28, 2019

@cmonr cmonr added ready for merge and removed needs: review labels Mar 28, 2019

cmonr added a commit to cmonr/mbed-os that referenced this pull request Mar 28, 2019

@cmonr cmonr merged commit cd8d362 into ARMmbed:master Mar 28, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9871 cycles (+772 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 28, 2019

@artokin artokin deleted the artokin:nanostack_armc6_update branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.