Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python modules to LICENSE file #10240

Merged

Conversation

Projects
None yet
5 participants
@fkjagodzinski
Copy link
Member

commented Mar 27, 2019

Description

Specify a license for every module from requirements.txt.

Fixes #10123

As you can see this list is not complete yet. I could use some help with a few modules marked as TODO. These cases need clarification.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[x] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@0xc0170

Release Notes

@ciarmcom ciarmcom requested review from 0xc0170 and ARMmbed/mbed-os-maintainers Mar 27, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

@fkjagodzinski, thank you for your changes.
@0xc0170 @ARMmbed/mbed-os-maintainers please review.

@cmonr

cmonr approved these changes Mar 27, 2019

Copy link
Contributor

left a comment

😲

@cmonr cmonr added needs: CI and removed needs: CI labels Mar 27, 2019

Show resolved Hide resolved LICENSE.md Outdated
Show resolved Hide resolved LICENSE.md Outdated
Show resolved Hide resolved LICENSE.md Outdated
Show resolved Hide resolved LICENSE.md Outdated
Show resolved Hide resolved LICENSE.md Outdated
Docs: Add Python modules to LICENSE file
Specify a license for every module from requirements.txt.

@fkjagodzinski fkjagodzinski force-pushed the fkjagodzinski:docs_update-license_py_modules branch from 53a524b to 5089253 Mar 28, 2019

@fkjagodzinski

This comment has been minimized.

Copy link
Member Author

commented Mar 28, 2019

Thanks @cmonr 👍, I've applied your changes and squashed the commits.
The PR is ready for review.

@cmonr

cmonr approved these changes Mar 28, 2019

@cmonr cmonr added needs: CI and removed needs: review labels Mar 28, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

CI started

@cmonr cmonr added needs: review and removed needs: CI labels Mar 28, 2019

@cmonr cmonr requested a review from ARMmbed/mbed-os-maintainers Mar 28, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

@ARMmbed/mbed-os-maintainers Would be nice for someone else to ack this before merge.

@0xc0170

0xc0170 approved these changes Apr 1, 2019

@0xc0170 0xc0170 merged commit fe9beae into ARMmbed:master Apr 1, 2019

15 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10024 cycles (+1033 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Apr 1, 2019

@fkjagodzinski fkjagodzinski deleted the fkjagodzinski:docs_update-license_py_modules branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.