Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Python 3 errors and lint warnings in build_release.py #10257

Merged
merged 3 commits into from Apr 12, 2019

Conversation

Projects
None yet
6 participants
@theotherjimmy
Copy link
Contributor

commented Mar 28, 2019

Description

I think this file is still used, and it's about time we updated it for
compatibility with python3. While I was in there, I fixed all of the
linter warnings, so that it's easier to spot bad code.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
Correct Python 3 errors and lint warnings in build_release.py
### Description

I think this file is still used, and it's about time we updated it for
compatibility with python3. While I was in there, I fixed all of the
linter warnings, so that it's easier to spot bad code.

### Pull request type

    [x] Fix
    [ ] Refactor
    [ ] Target update
    [ ] Functionality change
    [ ] Docs update
    [ ] Test update
    [ ] Breaking change
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 28, 2019

@theotherjimmy, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Mar 28, 2019

@bridadan
Copy link
Contributor

left a comment

Thanks for the clean up!

Show resolved Hide resolved tools/build_release.py Outdated
Show resolved Hide resolved tools/build_release.py Outdated
Show resolved Hide resolved tools/build_release.py Outdated
Apply suggestions from code review
Co-Authored-By: theotherjimmy <theotherjimmy@gmail.com>

@cmonr cmonr requested a review from bridadan Mar 29, 2019

Apply suggestions from code review

@0xc0170

0xc0170 approved these changes Apr 5, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

@bridadan waiting for your reivew

Show resolved Hide resolved tools/build_release.py Outdated
Show resolved Hide resolved tools/build_release.py Outdated
@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

@theotherjimmy Please respond to the review

Apply suggestions from code review
Co-Authored-By: theotherjimmy <theotherjimmy@gmail.com>

Comments addressed.

@cmonr cmonr added the needs: CI label Apr 12, 2019

@cmonr cmonr requested a review from bridadan Apr 12, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

CI started

@cmonr cmonr removed the needs: work label Apr 12, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

@bridadan I'm assuming that since the suggestions were taken, this is now good to go?

@bridadan
Copy link
Contributor

left a comment

I found one last nit pick but its not a big deal.

test_suite_properties=build_properties
)

print("\n\nCompleted in: (%.2f)s" % (time() - start))

This comment has been minimized.

Copy link
@bridadan

bridadan Apr 12, 2019

Contributor

Oh gosh, I missed one.

Suggested change
print("\n\nCompleted in: (%.2f)s" % (time() - start))
print("\n\nCompleted in: ({0:.2f})s".format(time() - start))

References (because I didn't know how this worked until now):

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 12, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Exporter restarted - internal CI symlink error

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 12, 2019

@0xc0170 0xc0170 merged commit 8160c34 into ARMmbed:master Apr 12, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+4 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9926 cycles (-676 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.