Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leftover waffle comments from README.md #10260

Merged
merged 1 commit into from Mar 29, 2019

Conversation

Projects
None yet
3 participants
@cmonr
Copy link
Contributor

commented Mar 28, 2019

Description

Thanks for the find @sg- !

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@cmonr cmonr requested a review from ARMmbed/mbed-os-maintainers Mar 28, 2019

@cmonr cmonr referenced this pull request Mar 28, 2019

Closed

waffle closing #10176

@cmonr cmonr added needs: CI and removed needs: review labels Mar 28, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

CI started

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 29, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

@cmonr please update the description with a meaningful comment. Even the title means nothing to the layman.

@cmonr cmonr changed the title Remove extra post-waffle cruft that was left behind Remove leftover waffle comments from README.md Mar 29, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

@adbridge done

@cmonr cmonr added ready for merge and removed needs: work labels Mar 29, 2019

@adbridge adbridge merged commit 5401cb6 into ARMmbed:master Mar 29, 2019

15 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9843 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.