Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated AWS url for astyle. #10275

Merged
merged 1 commit into from Apr 1, 2019

Conversation

Projects
None yet
5 participants
@cmonr
Copy link
Contributor

commented Mar 29, 2019

Description

The old AWS url is no longer appropriate for storing the astyle archive.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@cmonr cmonr requested review from ARMmbed/mbed-os-maintainers Mar 29, 2019

@adbridge
Copy link
Contributor

left a comment

AFAICT looks ok to me

@cmonr

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

Was originally intending to update the URL with the Travis CI update, but I guess I was a bit optimistic on the review speed for that PR: https://github.com/ARMmbed/mbed-os/pull/9844/files

Updated AWS url for astyle.
The original one is no longer appropriate

@cmonr cmonr force-pushed the cmonr:switch-aws-bucket branch from 99fbc33 to 6c9c7f1 Mar 29, 2019

@cmonr cmonr added needs: CI and removed needs: review labels Mar 29, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

CI started

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 31, 2019

@cmonr I'm confused, is this ready or does it need further review?

@cmonr

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

Whoops.

@NirSonnenschein It's ready, but needs a final OK from @ARMmbed/mbed-os-test-team (mainly @OPpuolitaival )

@cmonr cmonr removed the ready for merge label Apr 1, 2019

@0xc0170

0xc0170 approved these changes Apr 1, 2019

@OPpuolitaival

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

Both seems to be valid urls for now

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

starting CI

@0xc0170 0xc0170 merged commit 333da46 into ARMmbed:master Apr 1, 2019

15 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9872 cycles (+683 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.