Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Errors and Warnings from Arm Compiler 6 #10276

Merged
merged 1 commit into from Apr 1, 2019

Conversation

Projects
None yet
6 participants
@theotherjimmy
Copy link
Contributor

commented Mar 29, 2019

Description

Turns out we were not doing this. I think it's really important that
we display warnings when they exists.

Further, this makes the parse_output function run on the linker. It was
not run on the linker before.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@theotherjimmy theotherjimmy requested a review from bridadan Mar 29, 2019

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:armc6-parse branch from 08c1b04 to 992cb26 Mar 29, 2019

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Mar 29, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

@theotherjimmy, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@cmonr

cmonr approved these changes Mar 29, 2019

Copy link
Contributor

left a comment

🎉

@0xc0170

0xc0170 approved these changes Apr 1, 2019

@bridadan
Copy link
Contributor

left a comment

Do the other compilers now pick up linker errors as well? Like GCC and IAR? Or is that only implemented in ARMC6 for now?

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 1, 2019

@theotherjimmy

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

@bridadan They'll try, but I don't know how successful they'll be.

@theotherjimmy

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

I'll analyze that and make a follow on PR.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 1, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Apr 1, 2019

@cmonr cmonr merged commit 136e0e3 into ARMmbed:master Apr 1, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9981 cycles (+792 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.