Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for S2_LP (WiSUN) as a new MTB target #10281

Merged
merged 16 commits into from Apr 1, 2019

Conversation

@ashok-rao
Copy link
Contributor

commented Apr 1, 2019

Description

Adding STM32_F429 MCU + S2_LP (on a Module Carrier Board) as a new MTB target. This PR adds HW support for WiSUN supported targets in Mbed OS.

Greentea logs attached below:
MTB_STM_S2LP_GT_Logs_ARMC6_Pass.txt
MTB_STM_S2LP_GT_Logs_GCC_Pass.txt
MTB_STM_S2LP_GT_Logs_IAR_Pass.txt

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@0xc0170 @cmonr @jeromecoutant @mikter @JarkkoPaso

Release Notes

@ashok-rao

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

@0xc0170 / @cmonr : Can this get in for 5.12.1 as WiSUN is now released with 5.12.0 ?

cc @TuomoHautamaki ..FYI.

@ciarmcom ciarmcom requested review from 0xc0170, cmonr, JarkkoPaso, mikter, screamerbg and ARMmbed/mbed-os-maintainers Apr 1, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Show resolved Hide resolved targets/targets.json
@SeppoTakalo
Copy link
Contributor

left a comment

Please enable the S2LP radio by default. Otherwise looks good

Show resolved Hide resolved targets/targets.json
@JarkkoPaso
Copy link
Contributor

left a comment

I tested with the target board and works fine.

@0xc0170
Copy link
Member

left a comment

one file missing SPDX, otherwise LGTM

@0xc0170 0xc0170 added the needs: work label Apr 1, 2019

@0xc0170 0xc0170 removed the needs: review label Apr 1, 2019

@0xc0170 0xc0170 changed the title Adding support for S2_LP (WiSUN) as a new MTB target" Adding support for S2_LP (WiSUN) as a new MTB target Apr 1, 2019

ashok-rao added some commits Apr 1, 2019

Incorporating review comments
Removing USBDEVICE since USB pins are NOT brought out on the MTB/MCB.
@ashok-rao

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

@0xc0170 , Thanks! Now done.

@JarkkoPaso

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

Tested with 5cb1c64 and still works perfectly well.

@0xc0170

0xc0170 approved these changes Apr 1, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Apr 1, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Ci started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 1, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Apr 1, 2019

@cmonr cmonr merged commit 4dd55d2 into ARMmbed:master Apr 1, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9931 cycles (-60 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 1, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

@ashok-rao I dont understand what did cause this and no one noticed but there seems to be duplication of the commits (checking them, they do not look identical - causing some conflicts locally, will do manual patching)

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

This was not easy to resolve - please review #10326 - commits from this PR that are resolved properly.

@ashok-rao

This comment has been minimized.

Copy link
Contributor Author

commented Apr 7, 2019

Thanks @0xc0170 ..I don't understand what caused these conflicts either. Thanks for resolving. #10326 LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.