Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert limiting Renesas targets to ARMC6 #10288

Merged
merged 1 commit into from Apr 4, 2019

Conversation

Projects
None yet
7 participants
@bridadan
Copy link
Contributor

commented Apr 1, 2019

Description

These targets appear to run fine with ARMC5.

This reverts commit 2b75dfd.

It also fixes #10253.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SenRamakri

Release Notes

Revert "Only enable ARMC6 for a few targets"
These targets appear to run fine with ARMC5.

This reverts commit 2b75dfd.

@bridadan bridadan changed the title Revert "Only enable ARMC6 for a few targets" Revert limiting Renesas targets to ARMC6 Apr 1, 2019

@ciarmcom ciarmcom requested review from SenRamakri and ARMmbed/mbed-os-maintainers Apr 1, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

@bridadan, thank you for your changes.
@SenRamakri @ARMmbed/mbed-os-maintainers please review.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

I'm fine with the change, but do we remember why it was limited to ARMC6 in the first place?

CC @SenRamakri @bridadan @deepikabhavnani @ARMmbed/team-renesas

@cmonr

cmonr approved these changes Apr 2, 2019

@0xc0170 0xc0170 requested a review from ARMmbed/team-renesas Apr 2, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

@ARMmbed/team-renesas Please review

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 2, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 2, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added needs: review and removed needs: CI labels Apr 2, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

Making a note that we're waiting for a response to #10288 (comment) before bringing in.

@d-kato

d-kato approved these changes Apr 4, 2019

@cmonr cmonr added ready for merge and removed needs: review labels Apr 4, 2019

@0xc0170 0xc0170 merged commit 25371d4 into ARMmbed:master Apr 4, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9152 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.