Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples test compile optional verbose #10301

Merged
merged 2 commits into from Apr 9, 2019

Conversation

Projects
None yet
7 participants
@alekla01
Copy link
Contributor

commented Apr 3, 2019

Description

add examples test compile verbose cmd argument.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Apr 3, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

@alekla01, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@@ -391,7 +391,7 @@ def compile_repos(config, toolchains, targets, profile, examples):
valid_choices(example['toolchains'], toolchains),
example['features']):
print("Compiling %s for %s, %s" % (name, target, toolchain))
build_command = ["mbed-cli", "compile", "-t", toolchain, "-m", target, "-v"]
build_command = ["python", "-m", "mbed", "compile", "-t", toolchain, "-m", target] + (['-v'] if verbose else [])

This comment has been minimized.

Copy link
@theotherjimmy

theotherjimmy Apr 3, 2019

Contributor

This change is not explained in the commit message or in the Pull Request description. Could you please explain why you added python -m to the beginning of this command?

This comment has been minimized.

Copy link
@alekla01

alekla01 Apr 4, 2019

Author Contributor

Removed.

@theotherjimmy theotherjimmy requested a review from adbridge Apr 3, 2019

@0xc0170

0xc0170 approved these changes Apr 4, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 4, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 4, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added needs: review and removed needs: CI labels Apr 5, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

@adbridge I would like your review for this changeset

@adbridge
Copy link
Contributor

left a comment

LGTM

@0xc0170 0xc0170 merged commit 65ada92 into ARMmbed:master Apr 9, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9886 cycles (+669 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.