Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

equeue: align passed-in buffer #10304

Merged
merged 1 commit into from Apr 4, 2019

Conversation

Projects
None yet
7 participants
@kjbracey-arm
Copy link
Contributor

commented Apr 3, 2019

Description

Make equeue_create_inplace align the passed-in buffer and size to sizeof(void *).

Really we should be aiming to align more for ARM, as blocks should be 8-byte aligned, but the internal heap mechanisms only work to 4-byte alignment at the moment. More work would be needed to ensure 8-byte alignment of allocated blocks.

Rework of #10279. Fixes https://jira.arm.com/browse/IOTCORE-1112

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SenRamakri @teetak01 @JanneKiiskila @aashishc

equeue: align passed-in buffer
Make equeue_create_inplace align the passed-in buffer and size to
sizeof(void *).

Really we should be aiming to align more for ARM, as blocks should be
8-byte aligned, but the internal heap mechanisms only work to 4-byte
alignment at the moment. More work would be needed to ensure 8-byte
alignment of allocated blocks.

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:equeue_align branch from a0d1ed3 to db18c22 Apr 3, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

@teetak01 Can you test this change please?

@ciarmcom ciarmcom requested review from JanneKiiskila, SenRamakri, teetak01 and ARMmbed/mbed-os-maintainers Apr 3, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

started CI

@teetak01
Copy link
Contributor

left a comment

Verified to fix https://jira.arm.com/browse/IOTCORE-1112

@0xc0170

0xc0170 approved these changes Apr 4, 2019

@JanneKiiskila
Copy link
Contributor

left a comment

Looks good to me.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 4, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 4, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@JanneKiiskila

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

Merge time!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 4, 2019

@0xc0170 0xc0170 merged commit 0b69837 into ARMmbed:master Apr 4, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9179 cycles (-38 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.