Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: new state machine state and better info from stm #10324

Merged
merged 2 commits into from Apr 9, 2019

Conversation

Projects
None yet
7 participants
@jarvte
Copy link
Contributor

commented Apr 5, 2019

Description

Added new state (signal quality) and more information about progress so application/driver can build recovery logic.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AriParkkila

Release Notes

@ciarmcom ciarmcom requested review from AriParkkila and ARMmbed/mbed-os-maintainers Apr 5, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

@jarvte, thank you for your changes.
@AriParkkila @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@@ -902,7 +902,9 @@ void AT_CellularContext::cellular_callback(nsapi_event_t ev, intptr_t ptr)
if (ev >= NSAPI_EVENT_CELLULAR_STATUS_BASE && ev <= NSAPI_EVENT_CELLULAR_STATUS_END) {
cell_callback_data_t *data = (cell_callback_data_t *)ptr;
cellular_connection_status_t st = (cellular_connection_status_t)ev;
_cb_data.error = data->error;
if (ev != CellularStateRetryEvent) { // retry event may report errors but it's a retry so don't care about the error

This comment has been minimized.

Copy link
@AriParkkila

AriParkkila Apr 5, 2019

Contributor

May be removed?

This comment has been minimized.

Copy link
@jarvte

jarvte Apr 8, 2019

Author Contributor

removed

@0xc0170
Copy link
Member

left a comment

One commit having multiple logical things changed

int _status;
PlatformMutex _mutex;
cell_signal_quality _signal_quality;

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Apr 5, 2019

Member

cell_signal_quality vs cellular_connection_status_t - not having the same name scheme

This comment has been minimized.

Copy link
@jarvte

jarvte Apr 8, 2019

Author Contributor

fixed

@@ -161,7 +165,7 @@ class CellularStateMachine {

Callback<void(nsapi_event_t, intptr_t)> _event_status_cb;

CellularNetwork *_network;
CellularNetwork &_network;

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Apr 5, 2019

Member

how is this related to adding new connection status ? separate commit with explanation?

This comment has been minimized.

Copy link
@jarvte

jarvte Apr 8, 2019

Author Contributor

removed, will do this fix in a different pr.

@0xc0170 0xc0170 added needs: work and removed needs: review labels Apr 5, 2019

@jarvte jarvte force-pushed the jarvte:more_info_from_stm branch from 32a1015 to bd423ca Apr 8, 2019

@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

Forced pushed review fixes.

@0xc0170

0xc0170 approved these changes Apr 8, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 8, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Apr 8, 2019

@0xc0170 0xc0170 added needs: work and removed ready for merge labels Apr 9, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Please rebase, will restart CI

@jarvte jarvte closed this Apr 9, 2019

@jarvte jarvte deleted the jarvte:more_info_from_stm branch Apr 9, 2019

@sg- sg- removed the needs: work label Apr 9, 2019

@jarvte jarvte restored the jarvte:more_info_from_stm branch Apr 9, 2019

@jarvte jarvte reopened this Apr 9, 2019

Cellular: new state machine state and better info from stm
Added new state (signal quality) and more information about progress
so application/driver can build recovery logic.

@jarvte jarvte force-pushed the jarvte:more_info_from_stm branch from bd423ca to bb7fa99 Apr 9, 2019

Cellular: fix state machine to compile after master rebase
Fix automatic rebase error with cellulardevice.cpp

@jarvte jarvte force-pushed the jarvte:more_info_from_stm branch from bb7fa99 to 8234f00 Apr 9, 2019

@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

@0xc0170 rebase done. Also force-pushed fixes that were wrong after rebase.

@0xc0170 0xc0170 added the needs: CI label Apr 9, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Ci restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 9, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 9, 2019

@cmonr cmonr merged commit 2cb157c into ARMmbed:master Apr 9, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10213 cycles (+1049 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

Moved to 5.13.0-rc1.

Patch does not want to be applied successfully to the mbedf-os-5.12 branch, even by itself.

@jarvte jarvte deleted the jarvte:more_info_from_stm branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.