Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flagging WEAK method implementation for default construction #10363

Merged
merged 1 commit into from Apr 11, 2019

Conversation

Projects
None yet
6 participants
@hasnainvirk
Copy link
Contributor

commented Apr 10, 2019

Description

CellularDevice::get_default_instance() is a weak method and is overriden
by either a default construction provided in the code or by application
at some stage. This method needs to be flagged otherwise using another
driver will be hindered by the default overriding of this driver.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AnttiKauppila @AriParkkila @cmonr @0xc0170

Release Notes

@ciarmcom ciarmcom requested review from 0xc0170, AnttiKauppila, AriParkkila, cmonr and ARMmbed/mbed-os-maintainers Apr 10, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

@0xc0170 0xc0170 changed the title Flagging WEAK methoed implementation for default construction Flagging WEAK method implementation for default construction Apr 10, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Can you fix wording in the commit (I've already fixed the title).

@0xc0170 0xc0170 added needs: work and removed needs: review labels Apr 10, 2019

Flagging WEAK method implementation for default construction
CellularDevice::get_default_instance() is a weak method and is overriden
by either a default construction provided in the code or by application
at some stage. This method needs to be flagged otherwise using another
driver will be hindered by the default overriding of this driver.

@hasnainvirk hasnainvirk force-pushed the hasnainvirk:flagging_default_ctor branch from 739704f to 34fc828 Apr 10, 2019

@hasnainvirk

This comment has been minimized.

Copy link
Contributor Author

commented Apr 10, 2019

Can you fix wording in the commit (I've already fixed the title).

Sorry for the typo. Fixed.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Ci started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 10, 2019

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR
@alekla01

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

Restarted jenkins-ci

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 10, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 11, 2019

@0xc0170 0xc0170 merged commit d9ad62e into ARMmbed:master Apr 11, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(-36 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9165 cycles (-817 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.