Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PSA code generators #10364

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
7 participants
@orenc17
Copy link
Contributor

commented Apr 10, 2019

Description

  • Unify PSA generators
  • Replace scanning for mbed_spm templates with json
  • Make generate_source_files and parse_manifests common
  • Make assert_int an internal function
  • Use parse_manifests in pytests
  • Update docs

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

Refactor PSA code generators
* Unify PSA generators
* Replace scanning for mbed_spm templates with json
* Make generate_source_files and parse_manifests common
* Make assert_int an internal function
* Use parse_manifests in pytests
* Update docs
@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Refactor from #10286 , will just need @ARMmbed/mbed-os-maintainers review and CI (already reviewed by @alzix )

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Apr 10, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

@orenc17, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested review from alzix and removed request for ARMmbed/mbed-os-tools Apr 10, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 10, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 10, 2019

Test run: FAILED

Summary: 6 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
@mbed-ci

This comment has been minimized.

Copy link

commented Apr 10, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

Refactor from #10286 , will just need @ARMmbed/mbed-os-maintainers review and CI (already reviewed by @alzix )

Ready for integration

@alzix

alzix approved these changes Apr 11, 2019

Copy link
Contributor

left a comment

lgtm

@cmonr cmonr merged commit 2641fb3 into ARMmbed:master Apr 12, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(-36 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10256 cycles (+1051 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 12, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

This is essential for a customer for 5.12.3 so retargetting to this release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.