Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nordic QSPI data must be written from/read to aligned buffers in RAM #10380

Merged
merged 1 commit into from Apr 15, 2019

Conversation

Projects
None yet
5 participants
@j3hill
Copy link
Contributor

commented Apr 11, 2019

Description

Nordic requires that QSPI data must be written from/read to aligned buffers in RAM. Once the data is in RAM, it can then be copied/moved to other locations.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@j3hill j3hill requested a review from 0xc0170 Apr 11, 2019

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Apr 11, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

@j3hill, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

It would help how you found this issue. I see branch named fota

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 12, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

CI started

@j3hill

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

@0xc0170 We found this issue while trying to perform a firmware over the air (FOTA) update using external flash. Without this fix it is not possible to use Nordic QSPI functionality to directly read/copy the updated firmware from external flash into internal flash.

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 12, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

CI job restarted: jenkins-ci/exporter

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 15, 2019

@0xc0170 0xc0170 merged commit 1e3aa39 into ARMmbed:master Apr 15, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(-4 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9135 cycles (-1467 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@j3hill j3hill deleted the j3hill:FOTA_fix branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.