Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECHOTEST internal loop simplification and fix #10381

Merged
merged 1 commit into from Apr 16, 2019

Conversation

Projects
None yet
8 participants
@michalpasztamobica
Copy link
Contributor

commented Apr 12, 2019

Description

The loop was wrongly incrementing the index of the array after assigning
the value. Thus the first array element was used twice and the last one
was never user. The issue is fixed and the loops are refactored and
simplified to avoid such confusion in the future.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@VeijoPesonen
@blind-owl

@ciarmcom ciarmcom requested review from blind-owl, SeppoTakalo, VeijoPesonen and ARMmbed/mbed-os-maintainers Apr 12, 2019

@ciarmcom

This comment has been minimized.

@0xc0170
Copy link
Member

left a comment

Please fix astyle failures

@0xc0170 0xc0170 added needs: work and removed needs: review labels Apr 15, 2019

ECHOTEST internal loop simplification and fix
The loop was wrongly incrementing the index of the array after assiging
the value. Thus the first array element was used twice and the last one
was never user. The issue is fixed and the loops are refactored and
simplified to avoid such confusion in the future.

@michalpasztamobica michalpasztamobica force-pushed the michalpasztamobica:echotests_loop_fix branch from 55125c9 to 631540a Apr 15, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Ci started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 15, 2019

Test run: FAILED

Summary: 1 of 5 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
@alekla01

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

restarted jenkins-ci/mbed-os-ci_dynamic-memory-usage

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 16, 2019

@0xc0170 0xc0170 merged commit 79dddf8 into ARMmbed:master Apr 16, 2019

20 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/greentea-test Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 9182 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.