Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM MPS2: Cortex-M4 -> M4F & M7 -> M7FD #10386

Merged
merged 1 commit into from Apr 18, 2019

Conversation

Projects
None yet
7 participants
@kjbracey-arm
Copy link
Contributor

commented Apr 12, 2019

Description

According to their cmsis.h, FPU is present, so change targets.json to use it.

  • ARM_MPS2_M4: already was Cortex-M4F
  • ARM_MPS2_M7: Cortex-M7 -> M7FD
  • FVP_MPS2_M4: Cortex-M4 -> M4F
  • FVP_MPS2_M7: Cortex-M7 -> M7FD

If they do not in fact have FPU, then cmsis.h should be modified to set __FPU_PRESENT to 0. This will currently cause compilation problems with ARMC6, but I'll be submitting a fix for that.

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

@ChangwuShan Can you review? We discussed some FPU issues related to these targets.

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

@kjbracey-arm, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Apr 12, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

CI started

@ChangwuShan

This comment has been minimized.

Copy link

commented Apr 15, 2019

Looks ok on my side.

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 15, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_greentea-test

@cmonr cmonr added needs: work and removed needs: CI labels Apr 15, 2019

@alekla01

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

restarted jenkins-ci/mbed-os-ci_dynamic-memory-usage

@alekla01

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

restarted jenkins-ci/greentea-test

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Apr 16, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 16, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
ARM MPS2: Cortex-M4 -> M4F & M7 -> M7FD
According to their cmsis.h, FPU is present, so change targets.json to
use it.

* ARM_MPS2_M4: already was Cortex-M4F
* ARM_MPS2_M7: Cortex-M7 -> M7FD
* FVP_MPS2_M4: Cortex-M4 -> M4F
* FVP_MPS2_M7: Cortex-M7 -> M7FD

If they do not in fact have FPU, then cmsis.h should be modified to set
`__FPU_PRESENT` to 0. This will currently cause compilation problems
with ARMC6, but I'll be submitting a fix for that.

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:add_fpu_arm branch from b18f2af to a5d0c1c Apr 17, 2019

@kjbracey-arm

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

Rebased.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 17, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

@jamesbeyond Quick review ?

@0xc0170 0xc0170 merged commit 9157902 into ARMmbed:master Apr 18, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8584 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.