Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networking: Fix some ARMC6 warnings #10394

Merged
merged 1 commit into from Apr 18, 2019

Conversation

Projects
None yet
6 participants
@kjbracey-arm
Copy link
Contributor

commented Apr 12, 2019

Description

Some int-versus-long and signed-versus-unsigned format string mismatches, and missing class keyword.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Apr 12, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

CI started

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

#10395 - also in CI, if this one completes, we can merge this one as 10395 was already approved

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:networking_warnings branch from 87fe8f9 to 7fb9ae6 Apr 15, 2019

@kjbracey-arm

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

Just force pushed this to remove the stray "left shift" extra commit without reading any of the comments... Guess you were intending to merge that, making it a combo with #10395?

I can push it back to where it was, if that satisfies the CI.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Lets leave it as it is, restarting CI now

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 15, 2019

Test run: FAILED

Summary: 4 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
@alekla01

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

Restarted CI

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 15, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_exporter
@alekla01

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

restarted restarted jenkins-ci/mbed-os-ci_dynamic-memory-usage

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

Exporters error looks related - esp driver fails to build

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Apr 16, 2019

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:networking_warnings branch from 7fb9ae6 to 0bc5008 Apr 16, 2019

@kjbracey-arm

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

Needed to include <inttypes.h> - added.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Apr 16, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 16, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
@mbed-ci

This comment has been minimized.

Copy link

commented Apr 17, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
Networking: Fix some ARMC6 warnings
Some int-versus-long and signed-versus-unsigned format string
mismatches, and missing `class` keyword.

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:networking_warnings branch from 0bc5008 to 69c6cc3 Apr 17, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 18, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Will restart tests, seems like something happened to few targets (not related)

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 18, 2019

@0xc0170 0xc0170 merged commit 7392d51 into ARMmbed:master Apr 18, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 9390 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@kjbracey-arm kjbracey-arm deleted the kjbracey-arm:networking_warnings branch Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.